thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

Use loading page for posts/comments #1311

Closed micahmo closed 1 month ago

micahmo commented 1 month ago

Pull Request Description

This PR adds the loading page feature for post and comment links. The loading page was originally added in #1200, and it was to handle the case where we have an ambiguous link for a person or community, so we load the full object to verify whether it really exists before navigating. The loading page helps to bridge the gap while we fetch the object so the user knows something is happening.

I've been noticing that navigating to posts and comments has a similar problem where there seems to be no activity for a period of time (especially on a slower network). I believe this is because we similarly load the whole post/comment object before navigating, and unlike users/communities, we always load posts/comments, making the problem even more obvious. Furthermore, we often have to do a ResolveObject if the entity is on a different instance.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

https://github.com/thunder-app/thunder/assets/7417301/8b1ebad3-0107-4c87-980d-7993c31c4fba

After

https://github.com/thunder-app/thunder/assets/7417301/31990072-40ff-4398-8db8-b00527502971

Checklist