thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

Fix comment create page not allowing selecting original comment/post text #1315

Closed hjiangsu closed 1 month ago

hjiangsu commented 1 month ago

Pull Request Description

This PR fixes a regression from #1165 where the original post/comment was not selectable.

To do this, I've added selectable parameters to PostSubview and CommentContent. This selectable parameter is applied to the markdown body, so any text within the markdown body can be selected. This does mean that the metadata (author, upvotes, etc) cannot be selected but I believe that should be fine!

I also adjusted the filled background to be less "bright". The original post/comment should now be using the same background colour as the cross-posts background colour. Hopefully, this change is alright!

Review without whitespace

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Comment

https://github.com/thunder-app/thunder/assets/30667958/31ebcef3-c402-4d9a-b7a4-56160f5a945d

Post

https://github.com/thunder-app/thunder/assets/30667958/0fe0500a-48be-4735-a0ee-f9e9bd0939da

Checklist