thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

User and community avatar support in chips #1318

Closed iparks99 closed 3 weeks ago

iparks99 commented 1 month ago

Pull Request Description

Added toggle options to:

Wherever there is a User/Community Chip widget, the User/Community's avatar will be displayed if the appropriate toggle option is set to true.

Issue Being Fixed

Enhancement to display user and community avatars in post view.

Issue Number: #600, #1221

Screenshots / Recordings

image image image

Checklist

hjiangsu commented 3 weeks ago

Since the avatars may appear in other areas than these specifically (e.g., right now, the user avatar will appear in the post body, and in the future they may appear in the feed too), should these settings go under Appearance > Theming > Names?

Hmm, I think for now, we can leave them in their respective places. If the amount of settings become large enough, I was thinking of creating a new page to customize user/community avatars and chips under Appearance > User & Community Chips (maybe with a better name 😅). Thoughts @micahmo?

micahmo commented 3 weeks ago

I was thinking of creating a new page to customize user/community avatars and chips under Appearance > User & Community Chips (maybe with a better name 😅).

That makes sense to me! We could also put "Use Display Names" for both users and communities there!

hjiangsu commented 3 weeks ago

Yup, we don't have to do that in this PR though - it can be done separately! I'll go ahead and merge this one in. Thanks @iparks99 for the contribution again!