search

thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

Fix empty notifications #1324

Closed micahmo closed 3 weeks ago

micahmo commented 3 weeks ago

Pull Request Description

This PR fixes an issue with getting empty notifications generated by background checks. If it makes you better, I believe this was a regression that I introduced and was not related to the notifications refactor! :blush: I also snuck in another fix for generating usernames.

Followup to #1237.

micahmo commented 3 weeks ago

I decided to tack on another fix for duplicate channels in OS settings by assigning the same channel ID for the same channel name. Note that this does not affect message grouping since it is done by group key instead.

micahmo commented 3 weeks ago

I added one more tiny fix related to the payload of the message where we were adding the wrong ID (of the comment instead of the reply). Now I'm working on the account issue, but that will be separate.