thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

OLED color theme fixes, UI alignment fixes, community insert fix #1347

Closed CTalvio closed 1 week ago

CTalvio commented 2 weeks ago

Pull Request Description

This is a collection of tiny coloring and UI changes

Issue Being Fixed

The OLED theme has several places where things go awry if it is used together with material you. This looks to change theming so that material you colors are applied correctly.

I also did some small alignment fixes, and removed an extraneous divider that only shows up on ones own profile.

Maybe could have been a separate PR, but lastly this changes community insert action to simply pasting the ! format plaintext name of the community, as this is clickable in most clients without taking users off-instance. The insert also erroneously used an @ instead of an !.

Screenshots / Recordings

image image image image image

Checklist

micahmo commented 2 weeks ago

image

This should address one of @codenyte's issues here.

codenyte commented 2 weeks ago

Thanks so much for this PR, I was about to open an issue for the various bugs in the black theme. I feel like the Pitch black theme isn't tested as much as the light and regular dark theme.

CTalvio commented 2 weeks ago

@codenyte I'll likely be dailying the oled theme when this gets fixed. I want to use it but the various bugs in it bothered me too much.

Hopefully with my eyes on it it'll be better going forward.

codenyte commented 2 weeks ago

I've been using the theme for months (the first thing I do after downloading an app is checking whether there's a OLED/Pitch black mode) and although these issues infinitely bothered me, I never got around to file a bug report. Very happy that it's getting fixed. I'll also keep an eye out for this and report any issues after this gets merged.

codenyte commented 2 weeks ago

I found another weird quirk of the OLED theme:

This only happens when "Hide Top Bar on Scroll" is enabled

codenyte commented 2 weeks ago

Also, on the settings page, the search bar right beneath the top app bar looks kinda weird. Looks like it could use some padding on the top. Or just remove the gray background of the top app bar, I think it looks pretty bad (not just on the settings page).

CTalvio commented 2 weeks ago

I'm going to leave this PR unchanged to get it merged, but feel free to open an issue and list as many spots in the OLED theme that need fixing as you can find for me to address in a future PR.

codenyte commented 2 weeks ago

1353