thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

Disable Thunder's edge swipe to go back on Android #1350

Closed hjiangsu closed 1 week ago

hjiangsu commented 2 weeks ago

Pull Request Description

This PR disables Thunder's edge swipe to go back gesture when Full Swipe Gestures is disabled. This does not affect Android's system navigation gestures. For iOS, the edge swipe to go back will always be enabled regardless of the setting toggle because that's the primary way to navigate back on iOS devices.

@micahmo if you could test this out on a physical device and let me know, that would be great! I tested it on an emulator and it seems to be working as expected there.

Issue Being Fixed

Issue Number: #1340

Screenshots / Recordings

Checklist

hjiangsu commented 1 week ago

I'm still a bit unsure as to the cause of this bug because the page showed in the bug demo wasn't created with SwipeablePageRoute

Ahh yeah you're right - I wasn't able to reproduce that issue either. I think this is still a step in the right direction!