search

thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

Pure black theme UI quirks #1353

Open codenyte opened 2 weeks ago

codenyte commented 2 weeks ago

Bug Description

There are multiple problem with the Pure black theme, but I'll report as one issue. Thankfully some will already get fixed in PR #1347.

There are multiple issues with the top app bar, I'm not sure if this is the expected behavior but it has a grey-ish color while the rest of the app background is black. One example of this is the settings page: Either the search bar needs more padding at the top or the top app bar needs to have the grey background removed.

Another issue with the top app bar occurs on the Feed page when "Hide Top Bar on Scroll" is enabled: This could also be fixed by just removing the grey background, or by keeping it and also applying it to the notification/status bar (as it is the case when "Hide Top Bar on Scroll" is disabled).

Some sections of the app like "Explore instance" or "Create Comment'"don't use the black theme at all, even if it is enabled:

Steps to Reproduce

  1. Select Pure black theme
  2. Go to the aforementioned areas of the app

Additional Context

No response

App Version

0.4.0-1

Device

Pixel 6a

OS

Android 14 (GrapheneOS)

codenyte commented 2 weeks ago

Probably not that relevant, but the About -> Licenses screen doesn't use the pure black theme either:

codenyte commented 2 weeks ago

The Account settings page also looks pretty weird

CTalvio commented 1 week ago

Account settings will be fixed by my PR.

I'll eventually look at the rest as well, and any cases I find in my everyday use as well.

codenyte commented 1 week ago

Oh I'm sorry I didn't realize that this was included in your PR