search

thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
782 stars 68 forks source link

Imgur video thumbnails #1420

Open K4LCIFER opened 4 months ago

K4LCIFER commented 4 months ago

Is Your Feature Request Related to a Problem?

I've seen imgur videos without thumbnails

Feature Description

Provide thumbnails for Imgur videos

Alternative Solutions

No response

Additional Context

I'm not sure if this is an issue with all Imgur videos, or just failings for the one's that I have seen. Here is an example of one: Screenshot_20240604-155544

micahmo commented 4 months ago

Hey @K4LCIFER, thanks for the report! We generally rely on Lemmy to generate thumbnails for us as it can be very expensive for us to scrape websites and generate thumbnails from within Thunder. Can you see whether this post has a thumbnail on the web UI?

K4LCIFER commented 4 months ago

We generally rely on Lemmy to generate thumbnails for us as it can be very expensive for us to scrape websites and generate thumbnails from within Thunder.

Noted!

Can you see whether this post has a thumbnail on the web UI?

It does not. image

I shall close this issue then! Out of scope.

micahmo commented 4 months ago

You can possibly try the "Scrape Missing Link Previews" setting, but there's no guarantee it'll help. That's our backup for when Lemmy doesn't have a thumbnail, but it's off by default due to the extra overhead as mentioned.

micahmo commented 4 months ago

By the way, don't feel like you have to close these kinds of issues if they're not resolved for you. 😊 I'm just trying to be upfront about how (or if) we would possibly tackle this from our end.

K4LCIFER commented 4 months ago

By the way, don't feel like you have to close these kinds of issues if they're not resolved for you. 😊 I'm just trying to be upfront about how (or if) we would possibly tackle this from our end.

I appreciate it! Perhaps some tag like "on-hold" or "upstream" would be good if it is kept open?

micahmo commented 4 months ago

Good idea, we have several issues that rely on Lemmy server-side changes, so I think I'll make a corresponding label!