Highlight own comments

[CTalvio]

Is your feature request related to a problem? Please describe. Make one's own comments easier to spot by highlighting them somehow.

Describe the solution you'd like Highlight your own comments, perhaps by making your own username green?

[hjiangsu]

How does this look? I would need to also test it out with other Material You themes if possible, since currently, it just uses a static green colour

[CTalvio]

Using the accent colour, makes sense to me. Would make the app feel more cohesive.

[hjiangsu]

I've changed it to the following:

• username displays in primary colour, depending on what it is for your material you theme
• for the OP, i've changed it to be the secondary colour
• for admin, I've changed it to the tertiary colour

https://m3.material.io/theme-builder#/custom

[hjiangsu]

This has been added in the pre-release version v0.2.1-alpha.1+11. Feel free to test it out and see what you think!

[CTalvio]

It's not working at all.

I also can no longer edit my own comments, it just replies.

[CTalvio]

I'm trying to uninstall the app, and reset everything.

But even if I clear its storage before doing so, when I install it again, and open it for the first time.

I am already logged into my sopuli.xyz account.

Solved: https://stackoverflow.com/questions/33169618/an-android-app-remembers-its-data-after-uninstall-and-reinstall

[hjiangsu]

Hmm, thats weird - I did change the logic a bit in order to accommodate the swipe gesture customizability so I can take a closer look at this

[CTalvio]

I figured it out.

I was logged in using my account name, like this: mentaledge

But my display name is: MentalEdge

This broke something, and thunder was unable to tell which comments were mine.

I logged out and back in, this time entering my account name as: MentalEdge

And now it works.

[hjiangsu]

Ahhh - okay yeah, I was assuming it had something to do with username/display name thing. I'll try to make it more robust and use the user id rather than username to check if a comment is yours or not

[machinaeZER0]

I've changed it to the following:

* username displays in primary colour, depending on what it is for your material you theme

* for the OP, i've changed it to be the secondary colour

* for admin, I've changed it to the tertiary colour

I like this idea in theory, but an issue I'm seeing (if it's working, which I believe it is) is that certain Material You themes are going to be somewhat muted and/or utilize fairly similar looking colors (at least when it comes to being represented in something small like lettering). Example here of me talking with you in a post you created - my name pops out okay, but yours (as OP) was much less easy to recognize:

I think when it comes to something like this, it probably makes sense to either use colors that immediately draw the eye (and potentially are consistent regardless of theme choice - I actually liked your initial green text example!), or pair these roles (OP/Admin/your own posts) with icons? Or both? It'll be a little less clean, but I think (personally) it would make the most sense to do in this situation. What do you think?

[machinaeZER0]

This Jerboa screenshot shows off the use of icons, but also shows off another potential route to go - where material colors might not all stick out when used as the actual font color, making it the background of the username in question actually makes it pop in a big way!

Maybe some combination of these approaches would be worth trying out at some point?

[hjiangsu]

I think what I can do to keep it cleaner is to add chips as a way to distinguish OP, moderator, and admin statuses. I think icons are nice, but they are often times more distracting and should be used sparingly (similar to avatar or community icons)

However, feel free to let me know otherwise! I'm not a UI/UX designer by any means so maybe someone more knowledgeable than me can chip in (pun totally intended)

This is what I mean by chips: https://m3.material.io/components/chips/guidelines

[machinaeZER0]

Hahah, good one 😂 if chips are what they were using in that Jerboa screenshot I think that's a good experiment!

I love UI/UX and I get to play with it a lot for work, but by no means an expert. I do think it may be one of those situations though where (as opposed to something like a FAB, or nav icon color) it can be more helpful to use a consistent color that catches the eye, so that would be my only "concern" on the Material You front. That said, if the only people getting chips are yourself, OPs and admins then it probably won't lead to any crazy mixups :)

On Tue, Jul 4, 2023, 11:20 PM Hamlet Jiang Su @.***> wrote:

I think what I can do to keep it cleaner is to add chips as a way to distinguish OP, moderator, and admin statuses. I think icons are nice, but they are often times more distracting and should be used sparingly (similar to avatar or community icons)

However, feel free to let me know otherwise! I'm not a UI/UX designer by any means so maybe someone more knowledgeable than me can chip in (pun totally intended)

This is what I mean by chips: https://m3.material.io/components/chips/guidelines

— Reply to this email directly, view it on GitHub https://github.com/hjiangsu/thunder/issues/175#issuecomment-1620958344, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3UYV4O5EHEGHXP4AABHJLXOTMRJANCNFSM6AAAAAAZ3MJ5OI . You are receiving this because you commented.Message ID: @.***>

[CTalvio]

Dome and released, further discussion on how to distinguish mods and admins can continue here or in a new issue.