search

thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
732 stars 62 forks source link

Add refresh option other than scroll up #207

Closed CTalvio closed 10 months ago

CTalvio commented 11 months ago

The only way to trigger a feed refresh is currently to scroll all the way up.

My vote is for a refresh button next to the sort button in the top right, same as in inbox. it should also appear on community pages and for comments.

Also add pull down to refresh to inbox.

hbbit-dev commented 11 months ago

Been working on this issue, I successfully added a manual refresh button to the home screen, just working on getting a pull to refresh for the inbox, but I'm running into a lot of problems getting the refresh to activate. Tried using RefreshIndicator() when I tell it to onRefresh: context.read<InboxBloc>().add(const GetInboxEvent()); it throws an error.

Removing my work for the inbox until I can get something working, but I'll commit my other changes so hopefully we can get the refresh button on the home screen in the next release.

hbbit-dev commented 11 months ago

pull request relating to this issue, #213

hjiangsu commented 11 months ago

@bactaholic I'll assign this to you for now if thats okay!

hbbit-dev commented 11 months ago

@hjiangsu sure thing!

CTalvio commented 11 months ago

I spotted the refresh button in some new places. Nice.

I also noticed, that it is not possible to refresh on the comments and saved tabs in the profile view.

hbbit-dev commented 11 months ago

@CTalvio howdy, yeah I noticed it's missing from a few places as well. I'll be going through all the pages and adding refresh options where needed, just finished implementing pull-to-refresh in the inbox, but I gotta clean up my code and add a quick fix for an error when refreshing within communities, then I'll be moving onto adding refresh to all pages.

krestenlaust commented 11 months ago

Shouldn't this have an "fixed-in-upcoming-release"-tag?

hjiangsu commented 11 months ago

Yup, it should 😅 I was just busy yesterday and didn't have time to update the labels on some of these tickets

CTalvio commented 10 months ago

@bactaholic Bug report for you, when in "All" I noticed the button goes back to "Local posts" when used, while pull down to refresh does not.

hbbit-dev commented 10 months ago

@bactaholic Bug report for you, when in "All" I noticed the button goes back to "Local posts" when used, while pull down to refresh does not.

@CTalvio Dangit, I see that. I thought I had fixed all refresh issues with #216 / #227 but I guess not, I will get that done. It should be a simple fix.

CTalvio commented 10 months ago

I'm on the latest alpha. That particular issue is already fixed.

Essentially, refreshing does not just refresh the current feed, it also resets to your default, be that local/subbed/all.

hbbit-dev commented 10 months ago

I'm on the latest alpha. That particular issue is already fixed.

Essentially, refreshing does not just refresh the current feed, it also resets to your default, be that local/subbed/all.

Oh whoops, edited, fast reply lol. Yeah I will get it fixed in my current pull request, unless it gets merged into the develop branch before I can do so haha.

hbbit-dev commented 10 months ago

@CTalvio fixed in PR #245 , though I need to resolve the conflicts before it can be merged into the develop branch