More contrast in text for themes

[Fmstrat]

Is your feature request related to a problem? Please describe. With content displayed in the post feed, it's all starting to run together:

Describe the solution you'd like Updates to theming to support content adjustments, including expansion of themes to use a drop down with "System", "Dark", "Light" to be the defaults and "OLED" + others to be additional options.

Describe alternatives you've considered Making content displayed in the feed gray instead of white. Realistically, this could work, but a broader theme capability would be nice.

[machinaeZER0]

Oh yeah - in compact view the non-title text all looks to be a slightly darker shade, which I agree is helpful for readability when scrolling!

[CTalvio]

The color on the community name and instance should probably match between compact and normal.

[acidrums4]

I think choosing a bold(er) and a bit bigger font for post titles, and a lighter and dimmer font for metadata (magazine and instance names) could work.

I prepared this sketch with Inkscape to show what I mean. Note that I used the "Manrope" typeface as I did not have Roboto installed on my computer.

[machinaeZER0]

Yeah, this is pretty much exactly how compact mode handles font colors :)

On Sat, Jul 8, 2023, 6:53 PM acidrums4 @.***> wrote:

I think choosing a bold(er) and a bit bigger font for post titles, and a lighter and dimmer font for metadata (magazine and instance names) could work.

I prepared this sketch with Inkscape to show what I mean. Note that I used the "Manrope" typeface as I did not have Roboto installed on my computer.

[image: bitmap] https://user-images.githubusercontent.com/513421/252078143-ac580081-1273-46ea-81ae-f838a420bbd1.jpg

— Reply to this email directly, view it on GitHub https://github.com/hjiangsu/thunder/issues/223#issuecomment-1627536899, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3UYVZ67VABIPN5L3U3ULDXPHQGJANCNFSM6AAAAAAZ6DSTJM . You are receiving this because you commented.Message ID: @.***>

[CTalvio]

Should I make this change or is someone else already on it?

Also you can already set the post title font to be larger in the latest version, if you like.

[machinaeZER0]

This feels like it would be a total lay-up for me to try and tackle, but I've never done a PR before and I'm not sure where to begin :( presumably I'd find where the color values are set for normal and compact modes and then make them match?

[CTalvio]

This feels like it would be a total lay-up for me to try and tackle, but I've never done a PR before and I'm not sure where to begin :( presumably I'd find where the color values are set for normal and compact modes and then make them match?

Yes.

I'll get you started. The files are lib/community/widgets/post_card_view_comfortable.dart and lib/community/widgets/post_card_view_compact.dart.

[machinaeZER0]

Thank you! As mentioned over there, I don't actually know how to set up a build environment on Windows (or at all, honestly) to compile and test in Thunder myself, but looking at those two files side by side I believe I have been able to get compact and "normal" view to match with this PR?

Would be interested in setting up a test environment in the future! Would be cool to be able to help out in small ways such as this :)

[CTalvio]

It was not that difficult.

First: https://docs.flutter.dev/get-started/install Then check out the project in your IDE of choice: for example VScode

I'm using Android Studio on linux, as I've used it before, years ago.

[hjiangsu]

Thank you! As mentioned over there, I don't actually know how to set up a build environment on Windows (or at all, honestly) to compile and test in Thunder myself, but looking at those two files side by side I believe I have been able to get compact and "normal" view to match with this PR?

Would be interested in setting up a test environment in the future! Would be cool to be able to help out in small ways such as this :)

Hey, thanks for your interest in helping out! I think the hardest part in all of this is just setting up the environment. The link that CTalvio sent should be the best way to learn how to set everything up

If you do have questions on all this, feel free to join in the Matrix space and I can also guide you on the setup process: https://matrix.to/#/%23thunderapp%3Amatrix.org

Once you have the environment all set up, you'll have to learn a few commands for git, which is what is used to help with "pushing" or "committing" the code changes you've made :D

[machinaeZER0]

I thinkkkkk I have successfully created a pull request for this now, haha. Based my code off the dev branch this time

[machinaeZER0]

@hjiangsu I think this can potentially be marked as fixed in the next release?

[hjiangsu]

I'll temporarily marked this as fixed in the next release - however, I feel like this issue might encompass a few more things, so let me know if there's anything missing here and I'll remove the label

[Fmstrat]

I'll temporarily marked this as fixed in the next release - however, I feel like this issue might encompass a few more things, so let me know if there's anything missing here and I'll remove the label

Is there a separate issue for multi-themes?

[machinaeZER0]

What's a multi-theme?

[hjiangsu]

If you mean having the ability to select multiple themes or adding new themes, I don't believe theres an issue created yet for that (but it has been in discussion in a few places for example https://github.com/hjiangsu/thunder/pull/234)

I think we can create a new issue for supporting multi-theming!