search

thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
732 stars 62 forks source link

Upvote and downvote button color customization. #25

Closed jordan1776 closed 2 days ago

jordan1776 commented 11 months ago

Is your feature request related to a problem? Please describe. This is related to this discussion

Describe the solution you'd like Colors for up/downvote should by default match Lemmy's (blue #007bff for up and dark orange #873208). There should a setting in customization to use colors for reddit (orangered/periwinkle) and kbin (green/red)

Additional context Directly or indirectly asking the user in a first install OOBE what vote colors to user along with post view/gestures/etc could be a nice feature for the future.

ShambhavII-Singh commented 9 months ago

hi can you assign this to me?

jordan1776 commented 9 months ago

hi can you assign this to me?

You could check with the Matrix chat if anyone else is working on it. Looking back maybe asking for preset color combos might not have been the best choice and probably using the color picker dialog from "Accent colors" would be better (but I don't think that was a thing back then). One for upvotes and one for downvotes.

micahmo commented 9 months ago

Hey @ShambhavII-Singh, I've assigned this issue to you for now. As @jordan1776 said, you're welcome to join the devs in Matrix at https://matrix.to/#/#thunderapp:matrix.org. There you'll have a better idea of who's doing what. But of course, you're welcome to contribute without joining or even being assigned an issue. PRs are welcome!

To @jordan1776's point about colors, we have been leaning heavily into coloring elements based on the current theme using alphaBlend (example). But I also get the desire to set specific colors for upvote/downvote. Feel free to put together a proposal and we'll let the community weigh in!