thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
791 stars 69 forks source link

Ability to view images within the app hosted on external sites such as Imgur #45

Open Terkyz opened 1 year ago

Terkyz commented 1 year ago

Is your feature request related to a problem? Please describe. Yes, since it would be much more optimal to view the images directly from the app without having to open the integrated browser.

Describe the solution you'd like Have the image rendered in the app like any other image hosted directly on a Lemmy instance.

Describe alternatives you've considered I can open the link manually and it doesn't present any problem, but this is more optimal.

Additional context It would be super cool to also have Telegram-style previews of articles, instead of this, but I'm not sure if this needs its own issue.

hjiangsu commented 1 year ago

For this, it really depends on the image provider's APIs.

Integration with Imgur is definitely possible, but it might require API access, and depending on their policies, there might be a cost associated with it (e.g., like what Reddit is doing, except much more reasonable)

It would be super cool to also have Telegram-style previews of articles, instead of this, but I'm not sure if this needs its own issue.

That is definitely possible - currently theres only limited support for handling links (it'll fetch the image, and maybe the title of the article, but nothing more). I would suggest you to create a new issue for that to be tracked separately!

Generator commented 1 year ago

in addition to this, maybe on pixelfed too, user login to his pixelfed account, and upload to there and share url image on lemmy.
Not saying as a priority, maybe in a distance future

mario-g98 commented 1 year ago

May I add RedGIFs to the list? 😄

Imgur and RedGIFs (and others probably) are nicely implemented in Infinity For Reddit, maybe just take a look in their code?