hjiangsu
commented
1 year ago Just adding in my thoughts on how I feel like we should handle this error mode!
A toast notification seems to feel like the most natural way to go about this. Having a toast notification brings the user's focus to that notification in case of a failure whereas it might be more difficult to understand or see the change in icon.
If there is a change in the icon from the download to a X, it might not be immediately obvious to the user that they can retry the action.
When saving an image, the "save image" button becomes a checkmark if the image has been saved successfully. However, if the image cannot be saved, nothing happens and no error is shown.
In the following example the first image is saved to the library successfully, indicated by the button becoming a checkmark. The second image can't be saved, because it's a webp image and I'm on iOS 13, which doesn't support webp images.
https://github.com/thunder-app/thunder/assets/1429604/982f8d4a-1d71-4398-94c8-8729dd8434e2
However, regardkess of the reason why it failed, the user should be informed that saving the image failed. Possible solution would be the button becoming an X (maybe something similar to this, that would fit the style of the checkmark) or a message popping up saying that it failed (and maybe also why).