#665: Indicators for locked posts + reply prevention

thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter

https://thunderapp.dev

GNU Affero General Public License v3.0

732 stars 62 forks source link

#665: Indicators for locked posts + reply prevention #676

Closed ajsosa closed 9 months ago

ajsosa commented 9 months ago

Pull Request Description

Added a lock icon prefixing post titles for locked posts in both comfortable and compact view. Also replaced reply button in post view with lock as well as the FAB reply button. Commenting operations are blocked and a toast will notifying explaining that the post is locked.

Issue Being Fixed

https://github.com/thunder-app/thunder/issues/665

Screenshots / Recordings

snippet1 snippet2 snippet3 snippet4 snippet5

Checklist

[x] Did you update CHANGELOG.md?
[x] Did you use localized strings where applicable?
[ ] Did you add semanticLabels where applicable for accessibility?

ajsosa commented 9 months ago

@micahmo It just occurred to me that these changes will probably have merge conflicts with https://github.com/thunder-app/thunder/pull/648. I'm cool with reviewing and merging your stuff first and then fixing my PR.

CTalvio commented 9 months ago

Are we keeping the lock icons at the start of titles, and pin icons at the end? That seems inconsistent. Either change locked to be at the end, or pins and favorites to also be at the beginning.

ajsosa commented 9 months ago

@CTalvio Yeah I noticed that yesterday. I think I would prefer both to prefix the title so that their placement is always consistent.

micahmo commented 9 months ago

@ajsosa One thing I forgot to mention on the topic of the other indicators. Make sure the lock icon dims when the post is read. See here for example.

https://github.com/thunder-app/thunder/blob/develop/lib/community/widgets/post_card_view_comfortable.dart#L127

ajsosa commented 9 months ago

@micahmo Made the lock icon dim.

micahmo commented 9 months ago

Perfect! Did you still want to do #648 first, or would you rather this one goes first?

ajsosa commented 9 months ago

@micahmo I'll try to get to reviewing your changes later today. But if you would prefer to merge my stuff in first that's fine too. your call.

micahmo commented 9 months ago

I don't have a strong preference, so I guess we can just go in the order they were created if that's ok. (And I promise it's not just because it benefits me this time. 😆)

ajsosa commented 9 months ago

@micahmo Looks like there are no conflicts and my lock changes to FAB work seamlessly with your changes :D

micahmo commented 9 months ago

Sweet!!

micahmo commented 9 months ago

@ajsosa Did you intend to move saved to the beginning of the title? Looks like it's still at the end.

ajsosa commented 9 months ago

@micahmo I've never saved a post so had no idea that even existed. But yeah I can move it.

CTalvio commented 9 months ago

The padding on the pin icon is also on the wrong side now.