Closed micahmo closed 9 months ago
I like the new styling for 2! I do wonder if we should consider adding a little more padding to each option to ensure the popup options are easily tappable?
I do wonder if we should consider adding a little more padding to each option to ensure the popup options are easily tappable?
How does this look?
I think that's an improvement, thank you!
Do you have a screenshot of the Android launcher quick gestures for reference? I think maybe adding some side padding (left/right) would also look a bit better!
Also, another point for discussion, should the icon be on the left or right? I think most of the icons right now are on the left but let me know your opinions!
Do you have a screenshot of the Android launcher quick gestures for reference?
Of course!
I think maybe adding some side padding (left/right) would also look a bit better!
Do you mean to the left of the text and to the right of the icon?
should the icon be on the left or right?
To be honest, the only reason I kept the icons on the right is because that's how the extended fab options are displayed when not in combined mode. But that's really only because they're right-justified. I agree about moving the icons to the left here. In fact, that matches the Android actions too.
If it's not too much trouble I think shifting icons to the left side does make sense! I don't feel super strongly about it though :)
@hjiangsu and @machinaeZER0
How does the spacing/alignment look here?
I think thats better! It's a bit hard to see since the background is also white, but maybe just a little more vertical padding? Or have the background splash a bit darker so that the options are more in focus
have the background splash a bit darker so that the options are more in focus
I've actually been wanting to do this. In non-combined mode, I noticed the options don't stand out too much. In contrast with something like Google Cal where the background is almost completely hidden.
In lowered the background, added more spacing, and added more elevation. Thoughts?
I think thats much better! Thoughts @machinaeZER0?
I like it!
Oh - how does it look in dark/black mode?
I'll go ahead and merge this is as I think it looks good! If there are any further changes, we can add that in with a new PR
Yay! Will there be a new nightly soon? I'm excited to see all the improvements since the last one in action :)
@machinaeZER0 Yup, expect one to be released either today or tomorrow!
Yessssss
@hjiangsu Oops, I didn't commit the changes from the last screenshot as I was waiting for feedback, sorry! I'll open a new PR.
Pull Request Description
This PR contains a couple of minor visual fixes to the FAB.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before and After for number 1
https://github.com/thunder-app/thunder/assets/7417301/25b3816d-3ccd-4dc6-8580-b87d41943409
https://github.com/thunder-app/thunder/assets/7417301/b914ec22-930e-47c4-ae1c-20355c470745
Before and After for number 2
https://github.com/thunder-app/thunder/assets/7417301/c19641e1-e189-438c-840a-08bb25eeb5d0
Checklist
semanticLabel
s where applicable for accessibility?