Create an initial set of PHP Unit tests

[thybag]

• Basic actions for a controller or more.
• Check auth perms for scopes

[Djuki]

@thybag Is there a place for me to jump in and help?

[thybag]

Hi @Djuki, sure!

Re: Tests, it'd be great to have some basic ones setup for the controllers (Campaign/Image/Map/Entity/Blocks).

Laravel provides some nicer helpers for writing these https://laravel.com/docs/7.x/http-tests & https://laravel.com/docs/7.x/database-testing#resetting-the-database-after-each-test

As basic coverage I think it'd be nice to have a test for some of the basic policy/permissions stuff, ie.

• Generate data for a campaign
• As guest, i cannot view campaign index or view specific campaign
• As user who owns campaign i can see it in my index & view it
• As a user who does not own the campaign, i cannot see it (403) etc.
• Similar to the above for basic routes - I've yet to add validation so will likely be limited to success/fail based on permissions for now.

Then the same for the sub controllers, but with added (If I hit campaign/1/entity/2/ and entity 2 instead belongs to campaign 2 do I get an error type stuff) if you have time.

Whatever you have time to do would be great though.

[Djuki]

@thybag Thanks for the detailed answer. I will start on Monday by installing your app, and I will try to create HTTP tests. Then we can review and improve.