search

tiagodc / TreeLS

R functions for processing individual tree TLS point clouds
GNU General Public License v3.0
83 stars 28 forks source link

Reverse dependency check of lidR 2.1.0 #5

Closed Jean-Romain closed 4 years ago

Jean-Romain commented 5 years ago

Hi Tiago,

I ran a reverse dependency check on TreeLS v1.0 with the new version of lidR v2.1.0. In tlsNormalize documentation the example now have a warning.

tls = tlsNormalize(tls)
#> Warning message:
#> There were 3 degenerated ground points. Some X Y coordinates were repeated but with different Z coordinates. min Z were retained.

This is because grid_terrain now checks for degenerated ground points. See #264. R CMD check does not complain about that but I'm pretty sure that CRAN will.

tiagodc commented 5 years ago

Thanks, Jean! I'll fix the function before the next release. Cheers

Jean-Romain commented 4 years ago

This one is not a problem on CRAN actually. I'm just giving you the information