search

tiagosiebler / binance

Node.js & JavaScript SDK for Binance REST APIs & WebSockets, with TypeScript & browser support, integration tests, beautification & more.
MIT License
757 stars 266 forks source link

Investigate conditional type depending on beautifier enabled setting #125

Open tiagosiebler opened 3 years ago

tiagosiebler commented 3 years ago

Depending on whether the beautifier is enabled, some numbers may be strings: https://github.com/tiagosiebler/binance/blob/v2.0.0/beta/src/types/shared.ts#L1-L3

https://github.com/tiagosiebler/binance/blob/09cc8f11c0351ff50bd8e337fe3d5290ec919698/src/util/requestUtils.ts#L38

Would love to conditionally set the type to number or string, depending on the state of that setting. There must be a way...

tiagosiebler commented 1 year ago

See #226