Feature: added a function that gets subAccount deposit history from s…

[MartoMcfly]

…api/v1/broker/subAccount/depositHist

Signed-off-by: MartoMcfly martinpelaez@hotmail.es

Summary

Feature: added a function that gets subAccount deposit history from sapi/v1/broker/subAccount/depositHist

Additional Information

No breaking changes or dependencies added on this pull request

[Xavier59]

Response type different than the one described in api documentation. Which one is correct ?

https://binance-docs.github.io/Brokerage-API/Brokerage_Operation_Endpoints/#get-sub-account-deposit-history

@MartoMcfly

[Xavier59]

Can confirm typing were incorrect. Correct typings:

  getBrokerSubAccountDepositHistory(
    params?: GetBrokerSubAccountDepositHistoryParams
  ): Promise<BrokerSubAccountDepositHistory[]> {
    return this.getPrivate('sapi/v1/broker/subAccount/depositHist', params);
  }

export interface BrokerSubAccountDepositHistory {
    depositId: number,
    subAccountId: string,
    amount: string,
    coin: string,
    network: string,
    status: number,
    address: string,
    addressTag: string,
    txId: string,
    insertTime: number,
    sourceAddress: string,
    confirmTimes: string
}

Note: Binance documentation is a bit outdated too. Query returns an undocumented depositId attribute.

@tiagosiebler @MartoMcfly

[tiagosiebler]

Hey @Xavier59 almost missed this - silly question at a glance, does this mean that the typing in this SDK needs an update for that interface?

[Xavier59]

Yes @tiagosiebler , this interface need an update with the model I gave above :)

[tiagosiebler]

Yes @tiagosiebler , this interface need an update with the model I gave above :)

Thanks @Xavier59 - fixed via #328 in v3.6.0. Should be on npm shortly. In future, if you comment somewhere like here and I potentially missed it, please feel free to open a new issue. I read your comments a while back but then totally forgot about it since it was hidden away in this thread. Thanks for sharing the corrected type too!