search

tiagosiebler / binance

Node.js & JavaScript SDK for Binance REST APIs & WebSockets, with TypeScript & browser support, integration tests, beautification & more.
https://www.npmjs.com/package/binance
MIT License
771 stars 265 forks source link

Add support for WebSocket API (allows placing orders, canceling orders, etc. through a WebSocket connection) #283

Open anymos opened 1 year ago

anymos commented 1 year ago

Hi there, just saw it

it is accessible as wss://ws-api.binance.com:443/ws-api/v3 from this doc page : https://binance-docs.github.io/apidocs/websocket_api/en/#spot-testnet

My question is do you have any timeline in mind regarding the implementation for it ? just to have an idea :) thank you in advance @tiagosiebler !

tiagosiebler commented 1 year ago

Very cool to see commands & queries over WS on binance, was not expecting them to implement this any time soon. No specific ETA yet while this is in testnet, would love to see it mature and maybe also reach futures. If you want to take a stab at it, I'll gladly review a pull request proposing a way of doing this.

anymos commented 1 year ago

Hi there, I m testing it with a quick dirty fix. I am not sure I will be able to create a PR for it - to let you know

tiagosiebler commented 1 year ago

Hi there, I m testing it with a quick dirty fix. I am not sure I will be able to create a PR for it - to let you know

Sure, let me know how you get on - I can help you put up a PR if you've never done it before - it's worth knowing how to do it :) feel free to dm me on telegram: https://t.me/AlgoTraderL

anymos commented 1 year ago

Hi there, PR is not the issue my limited amount of time per day is ;)