tiagosiebler / binance

Node.js & JavaScript SDK for Binance REST APIs & WebSockets, with TypeScript & browser support, integration tests, beautification & more.
MIT License
734 stars 265 forks source link

Patch 1 #350

Closed MartoMcfly closed 11 months ago

MartoMcfly commented 11 months ago

Summary

  1. List All Convert Pairs
  2. Send quote request (USER_DATA)
  3. Accept Quote (TRADE)
  4. Order status (USER_DATA)
  5. Get Convert Trade History (USER_DATA)

Additional Information

  1. List All Convert Pairs
  2. Send quote request (USER_DATA)
  3. Accept Quote (TRADE)
  4. Order status (USER_DATA)
  5. Get Convert Trade History (USER_DATA)
MartoMcfly commented 11 months ago

Hello @tiagosiebler there seems to be a problem with my merge request, could you give me a hand?

MartoMcfly commented 11 months ago

@tiagosiebler Hello, could you give me a hand on why the circle test is not valid?

MartoMcfly commented 11 months ago

Thank you very much for the corrections, I have made the requested changes


De: Tiago @.> Enviado: jueves, 27 de julio de 2023 11:15 a. m. Para: tiagosiebler/binance @.> Cc: Martin Pelaez @.>; Author @.> Asunto: Re: [tiagosiebler/binance] Patch 1 (PR #350)

@tiagosiebler commented on this pull request.


In src/main-client.tshttps://github.com/tiagosiebler/binance/pull/350#discussion_r1275988864:

  • enableConvertSubAccount(
  • params: AcceptQuoteRequestParams
  • ): Promise; {
  • return this.postPrivate('sapi/v1/broker/subAccount/convert', params);
  • }
  • convertQuoteRequest(
  • params: ConvertQuoteRequestParams,
  • ): Promise; {
  • return this.postPrivate('sapi/v1/convert/getQuote', params);
  • }
  • getOrderStatus(
  • params: GetOrderStatusParams,
  • ): Promise; {
  • return this.getPrivate('sapi/v1/convert/orderStatus', params);
  • }
  • getConvertTradeHistory(
  • params: GetConvertTradeHistoryParams,
  • ): Promise; {
  • return this.getPrivate('sapi/v1/convert/tradeFlow', params);
  • }

Same for these

— Reply to this email directly, view it on GitHubhttps://github.com/tiagosiebler/binance/pull/350#pullrequestreview-1549391984, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2CW6CIRQVK6SSID3UB3RLDXSIWSHANCNFSM6AAAAAA2ZV3T4Q. You are receiving this because you authored the thread.Message ID: @.***>