search

tidymodels / tidymodels.org

Source of tidymodels.org
https://www.tidymodels.org/
17 stars 14 forks source link

Filtering of parsnip model table by package does not work #32

Closed hfrick closed 9 months ago

hfrick commented 1 year ago

This is the result of clicking on one of the packages in the drop-down menu for package:

Screenshot 2023-07-16 at 12 18 52
hfrick commented 1 year ago

It does work for the recipes and broom table :)

EmilHvitfeldt commented 1 year ago

No bugs, but misleading. {censored} does not provide any models. What this table shows is which package called set_new_model() for each model type, in this case {censored} doesn't https://github.com/search?q=repo:tidymodels/censored%20set_new_model&type=code.

I agree it looks weird, but we could think of another way to talk about "package" origin in the contest of this table

EmilHvitfeldt commented 1 year ago

No bugs, but misleading. {censored} does not provide any models. What this table shows is which package called set_new_model() for each model type, in this case {censored} doesn't https://github.com/search?q=repo:tidymodels/censored%20set_new_model&type=code.

I agree it looks weird, but we could think of another way to talk about "package" origin in the contest of this table

hfrick commented 1 year ago

Ah, I see! So this table was created when we still had model definitions in extension packages, makes sense. I think the content of this column should probably change to reflect where the engines are, rather than the model definition.