tidymodels / tidymodels.org

Source of tidymodels.org
https://www.tidymodels.org/
19 stars 15 forks source link

add tidydann to model spec search #41

Closed simonpcouch closed 9 months ago

simonpcouch commented 1 year ago

This PR adds tidydann to the model search page by re-running the parsnip model code in make_function_lists.R.

In the meantime, another package also contributed new model specifications:

anti_join(parsnip_models, parsnip_models_old) %>% select(title, engine, package)
#> # A tibble: 7 × 3
#>   title                                                          engine                package 
#>   <chr>                                                          <chr>                 <fct>   
#> 1 K-nearest neighbors                                            <code>cuda.ml</code>  parsnip 
#> 2 Random forest                                                  <code>cuda.ml</code>  parsnip 
#> 3 Linear support vector machines                                 <code>cuda.ml</code>  parsnip 
#> 4 Polynomial support vector machines                             <code>cuda.ml</code>  parsnip 
#> 5 Radial basis function support vector machines                  <code>cuda.ml</code>  parsnip 
#> 6 Discriminant Adaptive Nearest Neighbor Classification          <code>dann</code>     tidydann
#> 7 Discriminant Adaptive Nearest Neighbor With Subspace Reduction <code>sub_dann</code> tidydann

Although parsnip is able to correctly hook into cuda.ml's model registration, the package doesn't seem to have a pkgdown website, so the search page would refer people to parsnip's main model docs, which don't have information on cuda.ml. I'd make the case that we ought to add cuda.ml to excl in parsnip_pkgs <- parsnip_pkgs[!(parsnip_pkgs %in% excl)] but wanted to surface that here before doing so!

[EDITs: accidentally submitted issue early, finished typing description]

netlify[bot] commented 1 year ago

Deploy Preview for tidymodels-org ready!

Name Link
Latest commit 7b0eb74c128992b062bbdb1347223aa7b1785982
Latest deploy log https://app.netlify.com/sites/tidymodels-org/deploys/6595af645f5a3f0008ef0bf0
Deploy Preview https://deploy-preview-41--tidymodels-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilHvitfeldt commented 1 year ago

Great! let us send it in, after https://github.com/tidymodels/tidymodels.org/pull/40 is merged

simonpcouch commented 1 year ago

Awesome! Any opinions on the addition/exclusion of the cuda.ml specs?

EmilHvitfeldt commented 1 year ago

Yes, we should add cuda.ml to excl as you suggested

topepo commented 1 year ago

Let's hold off on this for a bit. The current plan is to make a new parsnip model

gmcmacran commented 10 months ago

Hey everyone,

I recently closed https://github.com/gmcmacran/tidydann/issues/7. I believe tidydann is ready for the addition to the model search page. I am holding off releasing the updates to CRAN until I get sign off here. Let me know how yall would like to proceed.

EmilHvitfeldt commented 10 months ago

Hello @gmcmacran! the search right now only works with models from packages on CRAN. If @topepo is happy with the changes, then you can send it to CRAN and I'll make it so it appears in the model search :)

gmcmacran commented 9 months ago

The changes have been uploaded to cran. Let me know if I need to do anything else.

https://cran.r-project.org/package=tidydann

EmilHvitfeldt commented 9 months ago

thank you! that is all we need, I'll get to this next week