Closed simonpcouch closed 9 months ago
Name | Link |
---|---|
Latest commit | 7b0eb74c128992b062bbdb1347223aa7b1785982 |
Latest deploy log | https://app.netlify.com/sites/tidymodels-org/deploys/6595af645f5a3f0008ef0bf0 |
Deploy Preview | https://deploy-preview-41--tidymodels-org.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Great! let us send it in, after https://github.com/tidymodels/tidymodels.org/pull/40 is merged
Awesome! Any opinions on the addition/exclusion of the cuda.ml specs?
Yes, we should add cuda.ml to excl
as you suggested
Let's hold off on this for a bit. The current plan is to make a new parsnip model
Hey everyone,
I recently closed https://github.com/gmcmacran/tidydann/issues/7. I believe tidydann is ready for the addition to the model search page. I am holding off releasing the updates to CRAN until I get sign off here. Let me know how yall would like to proceed.
Hello @gmcmacran! the search right now only works with models from packages on CRAN. If @topepo is happy with the changes, then you can send it to CRAN and I'll make it so it appears in the model search :)
The changes have been uploaded to cran. Let me know if I need to do anything else.
thank you! that is all we need, I'll get to this next week
This PR adds tidydann to the model search page by re-running the parsnip model code in
make_function_lists.R
.In the meantime, another package also contributed new model specifications:
Although parsnip is able to correctly hook into cuda.ml's model registration, the package doesn't seem to have a pkgdown website, so the search page would refer people to parsnip's main model docs, which don't have information on cuda.ml. I'd make the case that we ought to add cuda.ml to
excl
inparsnip_pkgs <- parsnip_pkgs[!(parsnip_pkgs %in% excl)]
but wanted to surface that here before doing so![EDITs: accidentally submitted issue early, finished typing description]