search

timdaman / check_docker

Nagios plugin to check docker containers
GNU General Public License v3.0
152 stars 60 forks source link

Add certificates files for docker engine daemon socket TLS #44

Open osfrance opened 6 years ago

osfrance commented 6 years ago

Add certificates files for docker engine daemon socket TLS for production environment (see https://docs.docker.com/engine/security/https/)

osfrance commented 6 years ago

Add modifications to check_swarm.py script

timdaman commented 6 years ago

Thanks for the PR. I am reviewing this change and looking into the test results. I will keep you posted.

MostFrabjous commented 5 years ago

This (still) works for the latest release. Would like to see it merged to master.

timdaman commented 5 years ago

Me too however there are still quality issues that need to be addressed. The tests need to pass and a error message should be added for bad argument usage. I don't have a test environment for this daemon configuration.

I would help but I have no good simulation of your environment to use for testing. Perhaps you can update the Vagrantfile to provide a Docker daemon with a suitable configuration?

Here are some hints on how I do testing. https://github.com/timdaman/check_docker/blob/master/DEVLOPEMENT.md

rbw commented 4 years ago

@osfrance @timdaman need help with this one?

timdaman commented 4 years ago

@rbw I could use some. The biggest issue is I don't have a Docker server setup with cert auth. I could try to make one but I figure someone who has something in the field should probably be the person to do that since they know what it should look like in operation.

Then there is writing up the tests and polishing the args, I can help with some of that but assistance is most welcome.