timescale / promscale

[DEPRECATED] Promscale is a unified metric and trace observability backend for Prometheus, Jaeger and OpenTelemetry built on PostgreSQL and TimescaleDB.
https://www.timescale.com/promscale
Apache License 2.0
1.33k stars 169 forks source link

In read-only mode shouldn't apply dataset config #1796

Closed zfy0701 closed 1 year ago

zfy0701 commented 1 year ago

Describe the bug In read-only mode shouldn't apply dataset config

https://github.com/timescale/promscale/blob/9df822a114e08cce67f792e6289a022a08ee7044/pkg/runner/client.go#L168-L178

otherwise it reports:

{"caller":"runner.go:94","level":"info","msg":"Migrations disabled for read-only mode","ts":"2022-12-14T21:15:28.032Z"}
{"caller":"client.go:91","level":"info","msg":"Skipping migration","ts":"2022-12-14T21:15:28.032Z"}
{"caller":"client.go:105","level":"warn","msg":"skipping schema version lease","ts":"2022-12-14T21:15:28.032Z"}
{"caller":"config.go:63","level":"info","msg":"Setting metric dataset default chunk interval to 8h0m0s","ts":"2022-12-14T21:15:28.102Z"}
{"caller":"config.go:64","level":"info","msg":"Setting metric dataset default compression to true","ts":"2022-12-14T21:15:28.102Z"}
{"caller":"config.go:65","level":"info","msg":"Setting metric dataset default high availability lease refresh to 10s","ts":"2022-12-14T21:15:28.102Z"}
{"caller":"config.go:66","level":"info","msg":"Setting metric dataset default high availability lease timeout to 1m0s","ts":"2022-12-14T21:15:28.102Z"}
{"caller":"config.go:67","level":"info","msg":"Setting metric dataset default retention period to 2160h0m0s","ts":"2022-12-14T21:15:28.102Z"}
{"caller":"config.go:68","level":"info","msg":"Setting trace dataset default retention period to 720h0m0s","ts":"2022-12-14T21:15:28.102Z"}
{"caller":"runner.go:127","err":"error applying dataset configuration: ERROR: cannot execute INSERT in a read-only transaction (SQLSTATE 25006)","level":"error","msg":"aborting startup due to error","ts":"2022-12-14T21:15:28.104Z"}

To Reproduce run promscale connect to timescale replica

Expected behavior should be able to correctly connect to db

Screenshots If applicable, add screenshots to help explain your problem.

Configuration (as applicable)

Version

Additional context