timescale / promscale

[DEPRECATED] Promscale is a unified metric and trace observability backend for Prometheus, Jaeger and OpenTelemetry built on PostgreSQL and TimescaleDB.
https://www.timescale.com/promscale
Apache License 2.0
1.33k stars 168 forks source link

Add struct tags to dataset config objects #1807

Open nhudson opened 1 year ago

nhudson commented 1 year ago

Description

This change adds the struct tags around the dataset.Config{} struct so we can use this as an external config validator. Without this you will get the following error when trying to Unmarshal data into the struct.

/Users/nhudson/.go/pkg/mod/github.com/timescale/promscale@v0.0.0-20221220155011-19d8e3e51658/pkg/dataset/config.go:39:2: encountered struct field "" without JSON tag in type "Config"
/Users/nhudson/.go/pkg/mod/github.com/timescale/promscale@v0.0.0-20221220155011-19d8e3e51658/pkg/dataset/config.go:40:2: encountered struct field "" without JSON tag in type "Config"

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR: