timfeirg / lain-cli

DevOps with minimum effort.
https://lain-cli.readthedocs.io/en/latest/
MIT License
31 stars 9 forks source link

[lain deploy] remove must_override_appname_when_cluster_specific_build #24

Closed timfeirg closed 2 years ago

timfeirg commented 2 years ago

instead, check for container re-creation after deploy.

closes https://github.com/timfeirg/lain-cli/issues/1

重复部署同一个 imageTag, 导致容器未重新创建, 提示效果如下:

image

书写了定制构建(cluster-specific build), 不允许使用 lain deploy --build, 提示效果如下:

image
codecov-commenter commented 2 years ago

Codecov Report

Merging #24 (caf4eec) into master (fea33ea) will increase coverage by 0.01%. The diff coverage is 60.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   56.58%   56.59%   +0.01%     
==========================================
  Files          14       14              
  Lines        3766     3797      +31     
==========================================
+ Hits         2131     2149      +18     
- Misses       1635     1648      +13     
Impacted Files Coverage Δ
lain_cli/lain.py 53.89% <51.72%> (-0.26%) :arrow_down:
lain_cli/utils.py 70.19% <68.96%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fea33ea...caf4eec. Read the comment docs.