Proposed minor updates - Githubissues

timwis / leaflet-choropleth

Choropleth plugin for Leaflet (color scale based on value)

http://timwis.com/leaflet-choropleth/examples/basic

MIT License

181 stars 232 forks source link

Proposed minor updates #21

Closed kernc closed 7 years ago

kernc commented 7 years ago

Move branching on valueProperty type out of the loop
Number of limits can differ from steps when mode is 'k'. Adjust steps to limits in such cases.

kernc commented 7 years ago

The tests are failing due to changes in how chroma.js quantizes, I suppose. Fixed by making them more robust by only testing the interval endpoints. If you'd prefer to have the new values hard-coded, I'm open to suggestions.

timwis commented 7 years ago

Thank you for this contribution, and please pardon my delay!