timwis / leaflet-choropleth

Choropleth plugin for Leaflet (color scale based on value)
http://timwis.com/leaflet-choropleth/examples/basic
MIT License
182 stars 233 forks source link

Drop bower support and remove compiled code from source control #23

Open timwis opened 7 years ago

timwis commented 7 years ago

Including dist makes it inconvenient to submit pull requests -- the submitter isn't sure whether to include it in the PR, and the author has no insight into whether the new compiled file accurately reflects the latest source code. I think instead we'd run the build command during npm publish. The gh-pages branch also needs it for the demos, so we could use travis to compile and push from the master branch to gh-pages.

This would probably mean bower no longer works, though, as there's no compiled version sitting on github. Do people still use bower? Any other advantages to having the built file in source control?