search

timwis / leaflet-choropleth

Choropleth plugin for Leaflet (color scale based on value)
http://timwis.com/leaflet-choropleth/examples/basic
MIT License
182 stars 233 forks source link

Possible to utilise chroma's domain setting? #25

Open landworth opened 7 years ago

landworth commented 7 years ago

Firstly, I love your choropleth plugin. It's working great, except the color scale setting isn't quite precise enough for what I need.

I've tried using chroma's domain setting (https://gka.github.io/chroma.js/#scale-domain) to be more specific about how it sets colors, but it doesn't seem to pass through your plugin.

Is it possible to enhance the plugin to utilize this setting?

Thanks in advance

timwis commented 7 years ago

Thanks! That sounds like a reasonable addition for an optional feature. Would you be interested in submitting a pull request that adds it?

landworth commented 7 years ago

Thanks Tim.. I'm up for submitting a pull request, but I'll be entirely honest and say I'm a newbie with Git. Any chance you can walk me through the process or point me in the right direction? Thanks!

timwis commented 7 years ago

Sure. The easiest way is to make the changes in GitHub's web editor: https://help.github.com/articles/editing-files-in-another-user-s-repository/

The more proper way to do it is to fork this repository, then clone your forked repository onto your computer, modify the files there, commit them and push them back to your forked repository, then click the "new pull request" button on your forked repository on github.com to propose your changes be merged into the parent/upstream repository.