tinygo-org / tinygo

Go compiler for small places. Microcontrollers, WebAssembly (WASM/WASI), and command-line tools. Based on LLVM.
https://tinygo.org
Other
15.25k stars 900 forks source link

tinygo source displeases linters #4225

Closed dkegel-fastly closed 3 months ago

dkegel-fastly commented 5 months ago

Eagle-eyed new contributors have noticed that the tinygo source tree does not pass some lint checks.

The project probably shouldn't rely on volunteers to run lint.

To address this, we might run lint in ci and/or add a "make lint" target in GNUMakefile.

To avoid adding too many new dependencies, we might want to keep the number of linters small, e.g. just go vet and revive, for starters, and avoid metalinters.

dkegel-fastly commented 5 months ago

Plain old lint target exists, runs one linter now, and several problems have been fixed.

I think we can close this now; further lint enhancements can continue without this bug report being open.

deadprogram commented 3 months ago

This was released with v0.32.0 so now closing. Thank you everyone!