Makefile: add lld to list of build targets for wasm-ld

tinygo-org / tinygo

Go compiler for small places. Microcontrollers, WebAssembly (WASM/WASI), and command-line tools. Based on LLVM.

https://tinygo.org

Other

14.73k stars 859 forks source link

Makefile: add lld to list of build targets for wasm-ld #4254

Closed paralin closed 2 months ago

paralin commented 2 months ago

The current list of targets does not build wasm-ld.

wasm-ld is a symlink created in ./llvm-build/bin pointing to ./lld.

Add the "lld" build target to get wasm-ld into ./llvm-build/bin.

Fixes a build failure where wasm-ld is not found.

paralin commented 2 months ago

CI Failure looks unrelated to changes in this PR

deadprogram commented 2 months ago

CI Failure looks unrelated to changes in this PR

You are correct. Restarted build and it passes.

aykevl commented 1 month ago

I wonder why this is needed? I don't see where wasm-ld is needed (unlike llvm-ar, llvm-nm etc which are needed in GNUmakefile).

paralin commented 1 month ago

I'm not sure, I just got a build failure saying that tool is missing, and then after adding it to the build targets, it's fixed. So, not sure where the actual issue was.