Closed ldemailly closed 3 months ago
Witholding comment for tonight other than to say fixing the little nits you have been running into is great... ideally each one of the little fixes would be its own PR, and some might even benefit from a simple test.
@ldemailly this PR would be a lot easier to review if it were actually 3 different PRs:
PR for "Add missing T.Deadline": https://github.com/tinygo-org/tinygo/pull/4356/commits/c8bd98d5dad4c6a44c4e870bea37a11b33ecb2d8
PR for https://github.com/tinygo-org/tinygo/pull/4356/commits/6465bee19f217f61d1a153eb01a9b8d7c43608e8 and https://github.com/tinygo-org/tinygo/pull/4356/commits/c8bd98d5dad4c6a44c4e870bea37a11b33ecb2d8
PR for https://github.com/tinygo-org/tinygo/pull/4356/commits/84ad1a00a40c4ed51f3317331985d789ac3c5101
None of these needs the PR in https://github.com/tinygo-org/tinygo/pull/4352 so it can just be based on the dev
branch.
Please let me know if this makes sense to you, and/or if I can help out in any way. Thanks!
done
Diff is stack on top of https://github.com/tinygo-org/tinygo/pull/4352 but once that one merges and I rebase it'll have only the top commit (not sure how you guys handle this)