tinygo-org / tinygo

Go compiler for small places. Microcontrollers, WebAssembly (WASM/WASI), and command-line tools. Based on LLVM.
https://tinygo.org
Other
15.48k stars 913 forks source link

More testing.T and go-cmp compatibility #4356

Closed ldemailly closed 3 months ago

ldemailly commented 4 months ago

Diff is stack on top of https://github.com/tinygo-org/tinygo/pull/4352 but once that one merges and I rebase it'll have only the top commit (not sure how you guys handle this)

dkegel-fastly commented 4 months ago

Witholding comment for tonight other than to say fixing the little nits you have been running into is great... ideally each one of the little fixes would be its own PR, and some might even benefit from a simple test.

deadprogram commented 3 months ago

@ldemailly this PR would be a lot easier to review if it were actually 3 different PRs:

None of these needs the PR in https://github.com/tinygo-org/tinygo/pull/4352 so it can just be based on the dev branch.

Please let me know if this makes sense to you, and/or if I can help out in any way. Thanks!

ldemailly commented 3 months ago

done