search

tiredofit / docker-nginx-php-fpm

Dockerized web server and interpreter image with many customizable options
MIT License
136 stars 34 forks source link

PHP_DISPLAY_ERRORS not work as expect #41

Open terryzwt opened 2 years ago

terryzwt commented 2 years ago

When the PHP_DISPLAY_ERRORS=FALSE, the php error message still display.

https://github.com/tiredofit/docker-nginx-php-fpm/blob/master/install/assets/php-fpm/fpm/php-fpm.conf#L32 the display_errors is always on

https://github.com/tiredofit/docker-nginx-php-fpm/blob/master/install/assets/functions/20-php-fpm#L228 This code will trigger only when PHP_DISPLAY_ERRORS is TRUE

So when PHP_DISPLAY_ERRORS is FALSE, nothing change.

terryzwt commented 2 years ago

BTW, is it possible to set the display_errors default value to false?

MatusSkerlik commented 2 years ago

@tiredofit could you please provide some statement about this feature ?

tiredofit commented 2 years ago

Looks like the code is by default deleting the line - PHP by default must be showing the errors. Rather than deleting we can easily shift to false to turn it off.

Let me do that.

tiredofit commented 2 years ago

OK 7.0.11 resolves this.