tjlane / pypad

Intuitive, high-level interface to the CSPAD
Other
2 stars 1 forks source link

check scaling of degrees of freedom that are optimized, such as z, theta, x, and y #26

Closed sellberg closed 11 years ago

sellberg commented 11 years ago

the objective function currently calculates the angular average for each quad and maximizes the product, it's the hard to control the scaling... if an error-around-the-mean objective function is implemented, where each variable is separated, we can control the RMS scaling for each variable. The scaling may affect the optimization significantly

tjlane commented 11 years ago

@sellberg I think we lucked out on this one by fortuitous choice of units. Our offsets are order unit (they are in mm) and the angles are in degrees, so they are also order unity. Hard to get much better.

I'll add a sanity check to the code, and we should keep this in mind for the future, but I don't think it's something we need to worry about right now.