Closed tjlane closed 10 years ago
tagging simple CXI parser: https://gist.github.com/tjlane/5930806
@rkirian : don't know if you ever generated an outline of a crystFEL geometry writer, but if you did, feel free to send it to me; would be good to add in that capability
@tjlane: I did write up a hack for this: look in the directory ~rkirian/cxi/current/config/geom for the files "testp2c" and "pypad2crystfel". See comments in testp2c.
Rick
On Jul 25, 2013, at 1:36 AM, TJ Lane wrote:
@rkirian : don't know if you ever generated an outline of a crystFEL geometry writer, but if you did, feel free to send it to me; would be good to add in that capability
— Reply to this email directly or view it on GitHub.
@rkirian I added a crystfel file writer, accessible via geomconv. Mind giving it a quick whirl to make sure everything looks good to you?
@tjlane Sure, no problem. I'll let you know how it goes in a bit. FYI, I just pulled the latest source and installed, but there seems to be no mention of crystfel formatting in the help:
cxia4113-psana0212> geomconv -h usage: geomconv [-h] -o OUTPUT -f {odin,cheetah,text} geometry
Convert a CSPad object (.cspad file) to another file format.
positional arguments: geometry A CSPAD Metrology, in .cspad format.
optional arguments: -h, --help show this help message and exit -o OUTPUT, --output OUTPUT The name of the file to write, containing the final mask. -f {odin,cheetah,text}, --format {odin,cheetah,text} The file format to write.
Rick
On Jul 30, 2013, at 7:50 PM, TJ Lane wrote:
@rkirian I added a crystfel file writer, accessible via geomconv. Mind giving it a quick whirl to make sure everything looks good to you?
— Reply to this email directly or view it on GitHub.
Rick,
Nice catch and thanks for the patch! Looks good to me.
You can reply to these github things via email and they get posted up on the issues. You can use email or the GitHub site directly, whatever you prefer. Having everything on the site is a nice record of what happened that has saved me a few times in the past.
TJ
PS. I get the following when I run geomconv -- maybe check one more time?
$ geomconv -h
usage: geomconv [-h] -o OUTPUT -f {odin,cheetah,crystfel,text} geometry
Convert a CSPad geometry file to another file format.
positional arguments:
geometry A CSPAD Metrology, in {.cspad, .h5, .geom, .dtc}
format
optional arguments:
-h, --help show this help message and exit
-o OUTPUT, --output OUTPUT
The name of the file to write, containing the final
mask.
-f {odin,cheetah,crystfel,text}, --format {odin,cheetah,crystfel,text}
The file format to write.
Closing this until someone complains. Mikhail has promised he will give me some code -- hopefully he does!
Mikhail has obliged: https://gist.github.com/tjlane/6143974. It would be good to at least have the ability to write psana params -- I may even be able to reverse-engineer the conversion to be able to read psana parameters
The following need to get done:
read: odin detectorsread: CXIdb cheetah h5swrite: CrystFEL geomSecond to last I will probably not do unless someone bugs me. The last is long term. I'm not really capable of doing it, but Mikhal could if need be.