search

tjlane / pypad

Intuitive, high-level interface to the CSPAD
Other
2 stars 1 forks source link

Assemble #42

Closed tjlane closed 11 years ago

tjlane commented 11 years ago

New assembly algorithm. Very similar to the old one, but cleaned up and more sane. Fixes #39, #34.

Ready to merge. @sellberg, if you're game, check out this branch and test it out to catch any last possible bugs. If everything looks good feel free to hit the merge button!

If you want, feel free to preform a code review on the below as well. Never hurts to have a second pair of eyes/opinions.

tjlane commented 11 years ago

ps here are the old & new assembly images (though now those orange dots are gone):

old_assemble newest_assemble

sellberg commented 11 years ago

Seems to work fine for both assemble and score, this closes #39, #34

sellberg commented 11 years ago

@tjlane can i delete branch assemble from the repo?

tjlane commented 11 years ago

Go for it — Sent from my iPhone

On Sat, Jul 27, 2013 at 2:08 PM, Jonas Sellberg notifications@github.com wrote:

@tjlane can i delete branch assemble from the repo?

Reply to this email directly or view it on GitHub: https://github.com/tjlane/pypad/pull/42#issuecomment-21672549