search

tjlane / pypad

Intuitive, high-level interface to the CSPAD
Other
2 stars 1 forks source link

Base #48

Closed tjlane closed 11 years ago

tjlane commented 11 years ago

This PR primarily addresses issue #33, but also includes a refactor of the pypad code that plots the CSPAD on in a left panel and integrated intensities in a right panel.

@sellberg @rkirian : if one or both of you guys can check out this branch and give the new tweak script a whirl, report bugs, etc, that would be awesome.

The script is currently slow but pretty full-featured. I've only tested gold, though. @sellberg, maybe you can test ice?

sellberg commented 11 years ago

@tjlane seems to work well for gold, except that when I press left arrow the scripts decides to un-zoom (it doesn't do this for up/down/right), which is very annoying. Otherwise I like the layout of the script, how do you calculate the rings? based on the same peak finder as in score ?

trying the ice next...

sellberg commented 11 years ago

@tjlane seems to work nice for the ice as well, although i don't get how it decides what rings to plot (see below). would be sweet if it determined the rings the same way as is done in the score peak finder, which it doesn't seem to do... also, a BACK option like CTRL+Z would be nice to have when tweaking, but it I dunno if it's difficult to implement. If you can keep a copy of the internal cspad geometry before the last click, it should be easy to implement.

t229k-9um-20adus-ice-raw-tweak_rings

t229k-9um-20adus-ice-raw-tweak_center

tjlane commented 11 years ago

Jonas, cool thanks.

As for the issues you pointed out:

(1) The "unzoom" on back is likely due to the fact that, by default, MPL binds the back arrow to the "back" operation (the button you can click in the bottom left of the MPL screen). maybe we should rebind our move keys to ijkl, or I can override that default... thoughts?

(2) Mess w/the params here: https://github.com/tjlane/pypad/blob/base/scripts/tweak#L192 and see if you can get the ice looking good. We can also expose these parameters to the user if need be, but my hope was that as long as just one or two rings showed up, that would be enough.

(3) Can make a back button, but let's merge this PR and make a separate issue.