is_valid_profile soft/hard blacklist patch

[GoogleCodeExporter]

There are some plugins (sockets/sockscan) that still show up in the --help 
plugins list when a Windows 7 profile is specified. That's because we don't 
define Plugin.is_valid_profile for them yet. This patch adds is_valid_profile 
methods to all remaining plugins** that need it (according to 
[FeaturesByPlugin21]. Additionally, it adds "hard" blacklisting where I 
_believe_ that should be necessary. The "soft" blacklisting (i.e. usable but 
hidden from --help) is a good start, but the more I think about it, I can't 
think there would ever be a situation to use netscan on xp, sockscan on vista, 
etc. 

** except hashdump/lsadump...info on that is still pending

Original issue reported on code.google.com by michael.hale@gmail.com on 10 Jul 2012 at 2:54

Attachments:

• is_valid_profile.patch

[GoogleCodeExporter]

Looks good to me.  The error message seems a little terse and in my head, I 
figure people will want the command they're trying, they're more likely to have 
forgotten/put in the wrong profile entry, so "invalid profile for command" 
seems more logical to me.  Either way, it might be more descriptive/easier to 
understand if it were expanded to "This command does not support the selected 
profile." or "is not compatible with" or something like that?

Original comment by mike.auty@gmail.com on 10 Jul 2012 at 7:00

[GoogleCodeExporter]

Thanks Mike. This was fixed in r2017, I went with "This command does not 
support the selected profile."

Original comment by michael.hale@gmail.com on 10 Jul 2012 at 2:21

• Changed state: Fixed