search

tlambert03 / LLSpy

Lattice light-sheet post-processing utility.
http://llspy.readthedocs.io
Other
27 stars 6 forks source link

made logo smaller to prevent crashes on some X windows configurations #24

Closed VolkerH closed 5 years ago

VolkerH commented 5 years ago

This is a simple change (resized the application icon to a smaller size) that prevents crashes of the LLS GUI on startup on some X window setups. This took me quite a while to get to the bottom of.

What's the issue to fix: When logging into our Linux GPU workstation via VNC (tightVNC server on workstation, TurboVNC client on laptop) and trying to start lls gui I would see the following:

image

When running on the actual workstation or when logging in via X-forwarding the problem was not present. Googeling the error message seemed to hint that this affects a number of Qt-based applications in combination VNC servers as well as some X-Servers (X-Ming). The cause seem to be icons that are too large. See for example here: https://stackoverflow.com/questions/23901229/why-does-qt-crash-when-loading-a-window-icon

In this pull request I scaled down the logo to 20% of the original length/width. With this workaround (the actual bug seems to be in Qt) I can run lls gui via VNC.

tlambert03 commented 5 years ago

wow! impressive sleuthing. thank you! I have a couple other things I've been needing to check before the next release, but I'll try to get on it sooner than later so that this can be included.

tlambert03 commented 5 years ago

just wanted to let you know that I updated the icon file one more time in ff3b054751f8b8649ba34508bbbb27d6e2edb530 to reintroduce the transparency in the logo. that increased the size a few kB... so let me know if it still works for you when you get a chance.

VolkerH commented 4 years ago

just intalled the latest version from conda-forge and it works with the bundeled logo