search

tls-kr / tls-app

Web Application for TLS
8 stars 3 forks source link

Occurrences of expressions are no longer counted automatically #178

Closed matchachoco95 closed 3 weeks ago

matchachoco95 commented 10 months ago

Describe the bug A bit of a minor issue but it seems as though occurrences of expressions are no longer counted automatically in singular texts. As you can see in the first attached screenshot, I looked for the phrase 而一 in just one text (the 算數書) and every occurrence (even though they clearly appear in different passages) is marked with a 1. Furthermore, on the top part it says "found 1 match" which obviously is not true. When searching in all texts, the problem is not present (see second screenshot).

To Reproduce Steps to reproduce the behavior:

  1. Go in any text.
  2. Look for a specific expression.

Expected behavior A count of all occurrences should appear at the top, and different occurrences should be counted as such.

Screenshots image image

Desktop (please complete the following information):

cwittern commented 10 months ago

Yes, I know this is a bit of a weird thing. A while ago, we changed the search code, and as a result 'matches' are counted per paragraph, but the 'matches' are displayed for every line, as before. So if a paragraph contains several matches, the same number for a match will be displayed multiple times. It is mainly a confusing interface-issue, but I will see how to resolve it to a more straightforward way of displaying.