tnightengale / dbt-activity-schema

A dbt-Core package for generating models from an activity stream.
GNU General Public License v3.0
38 stars 5 forks source link

Min Max Aggregations Do not Work Correctly for Non Timestamp Columns #22

Closed tnightengale closed 1 year ago

tnightengale commented 1 year ago

CC: @bcodell

I realized that the append timestamp, aggregate and trim functionality that we are using for the feature_json column, is not being applied to other columns, when it needs to be.

See the draft PR #23 with the failing integration test, for the minimum revenue_impact for example:

Screenshot 2023-03-21 at 2 26 22 PM