search

tobias-richter / ansible-tasmota

Ansible Role for managing tasmota devices with tasmota commands
Apache License 2.0
31 stars 12 forks source link

Support for MQTT Configuration in a single Backlog command #17

Closed deveth0 closed 3 years ago

deveth0 commented 3 years ago

If you don't set values for those fields, they are not set, so I think it's fine to support the full set and only set those fields that are configured.

As mqtt is a basic functionality of tasmota, it justifies a build in block imho.

tobias-richter commented 3 years ago

@deveth0 In my setup I have not set these values and i was not required to. I am only setting FriendlyName1 and DeviceName and enabling the home assistant integration and it works like a charm ootb without setting topic and fulltopic. If I now want to adjust the basic mqtt settings based on your implementation I have to lookup the automatically configured values and port them to the configuration management. From my point of view this would be a little bit awkward.

deveth0 commented 3 years ago

Nope, cause the default is an empty string which does not cause a change (using commands without value are just read commands for the current value). So if your want to set the host, you only set the host value and leave the others.

tobias-richter commented 3 years ago

Let's have a chat about this next week. I still see no need for this since it does not offer new functionality. Everything is already possible with the existing implementation and it is simply an new command entry that is passed to the action module.

Beside that it will not report a valid changed/not changed response.