search

tobias-richter / ansible-tasmota

Ansible Role for managing tasmota devices with tasmota commands
Apache License 2.0
31 stars 12 forks source link

Fix/minor improvements #30

Closed zkygr closed 8 months ago

zkygr commented 10 months ago

Hello,

i updated the example in the readme, because the name of the role was wrong. There was an underscore instead of a dash.

I also run in the issue that the mqtt part failed because my tasmota_mqtt_port was an integer and not a string and i got no feedback because no_log is always true. Now the user can switch this to false.

zkygr commented 9 months ago

Hello, and thanks for your fast reply :)

You are absolutly right, i fucked up my import statement in the requirements.yml:

  - name: tobias-richter.tasmota
    src: https://github.com/tobias-richter/ansible-tasmota
    version: 1.10.0

I corrected the readme changes in the squash commit.

zkygr commented 9 months ago

Should this role actually be executed on Tasmota devices? Since only the API is being used, it is more likely to be outsourced to localhost, right? That would be the 2nd fixup commit.

zkygr commented 9 months ago

If the changes are okay with you, i would squash both commits.