search

tobozo / YOURLS-GeoShortURL

🔗 YOURLS plugin to add per-country support to existing short URLs
MIT License
7 stars 2 forks source link

can't create country URL using "-" #3

Open Akila3 opened 2 years ago

Akila3 commented 2 years ago

I am trying to create a country specific URL using the "-xx" in the short name but once I create it the yourls removes the "-" symbol. example , create "http://mydomain.xx/site" for every one and than I want to create a dedicated separated site for France (example) so i try to create "http://mydomain.xx/site-fr". YOURLS changes it automatically to "http://mydomain.xx/sitefr", removing the "-" and the geo targeting doesn't work. any idea how to solve this problem

tobozo commented 2 years ago

Hey thanks for your feedback :+1

You probably need to enable the "hyphens in URLs" core plugin.

https://github.com/YOURLS/YOURLS/blob/master/user/plugins/hyphens-in-urls/plugin.php

Akila3 commented 2 years ago

I think it solved the problem your reply :) thank you for quick response.... another question or a feature request. is it possible to make this plugin integrated with the regular URL shortening UI/Tool bar as additional option instead as creating another short url per country? meaning that the plugin will add option (array) for country and redirects in the regular shortening UI with geo options in it. that way you end up with one URL short with geo targeting in it instead on multiple URL shorts.

tobozo commented 2 years ago

Nice idea! And it's mutually complementary with @dragosion's continental fallback suggestion.

I don't have my hands anymore on a multiple-TLD webserver so I can't test that, but feel free to submit a PR.

Akila3 commented 2 years ago

I just use VPN to test locations. Windscribe, is a free option if you like. i personally have a paid subscription, so I can do testing. I just don't have the coding skills to create it. what is a PR and it's purpose?

tobozo commented 2 years ago

what is a PR and it's purpose?

A PR is a pull request, its purpose is to suggest code changes to a project.

You won't need that though, YOURLS-GeoShortURL is a plugin item while you're expressing the need for a toolbar item, which is a completely different structure.

I just don't have the coding skills to create it.

Neither have I, but I don't listen to my inner voice when it comes to self esteem :wink:

The reason why I can't do it is because I don't have the infrastructure/time/energy necessary to test that any more. I used to have access to all these resources but that was years ago when I wrote this plugin.

If you feel like experimenting, the toolbar item folder is the project template you're looking for.

The community is very active and helpful too, you will probably need to document yourself on the YOURLS API before posting questions though (otherwise you might not understand the answers).