search

tolmasky / demokit

DemoKit is a Library and Electron app for building product demos and tutorials using web technologies
MIT License
428 stars 17 forks source link

Various fixes, zoom support, dependencies for real terminal emulation #20

Open ajbouh opened 6 years ago

ajbouh commented 6 years ago

@tolmasky ping

tolmasky commented 6 years ago

Hi I'm just about to jump on a plane but didn't want this to go unresponded to. I'm going to try my best to look at this this week. Thanks!

ajbouh commented 6 years ago

Great, thanks!

I have more changes that make it easier to sync terminal keyboard events with terminal output. That way you can avoid the terminal falling behind your typing and ruining the line wrapping.

I've also been experimenting with getting hover events to show up properly during simulated mouse movement. Looking forward to getting your perspective on that as well.

ajbouh commented 6 years ago

@tolmasky still interested in merging this? I have a separate set of patches based on this that updates to electron v3

tolmasky commented 6 years ago

Hi abjouh, sorry for the delay -- I think if we can split these up a bit, it would help me taking it in, since currently whenever I have a little time, I start and never finish reviewing it all.

Specifically, it would be nice to split easy fixes like Electron updates, from "UI fixes" like the zoomLevel stuff, to potentially security affecting fixes like adding node-pty (where if you run demokit with that on it could potentially allow arbitrary websites to gain access to your computer).

One of the ideas of DemoKit is that you might want to run it in CI for example, and I'd want to at the very least significantly document the dangers of turning on node integration if we have that feature since some people may not know what that allows.

ajbouh commented 6 years ago

Reduced these to the four simplest ones. Will push other PRs for other features individually.