tom-- / yii2-dynamic-ar

An extension to add NoSQL-like documents to Yii 2 Framework's Active Record ORM.

ISC License

57 stars 15 forks source link

extracted encoder to be able to add other dbs #11

Closed nineinchnick closed 3 years ago

nineinchnick commented 9 years ago

IMHO encodeForMaria and decodeForMaria should be private and at least the interface method naming should be improved.

Also, some DynamicActiveRecord methods could be moved to a trait or a helper class.

tom-- commented 9 years ago

I should have said as my first comment:

Thank you!

We're definitely going to adopt this. But I don't want to merge it into master yet. Some people are tracking master as a dependency and I don't want then to have this churn. So I pulled your two new branches in here. I think it's probably OK to drop the extract-encoder branch and work in the pgsql-branch. Agreed?

nineinchnick commented 9 years ago

Somehow I missed that comment. Agreed. I'm going to look into the pgsql version soon.