tomaae / homeassistant-openmediavault

OpenMediaVault integration for Home Assistant
Apache License 2.0
109 stars 16 forks source link

[Bug] 'Failed to set up' caused by compose plugin #114

Closed cdjockey closed 1 year ago

cdjockey commented 1 year ago

Describe the issue

Integration warns 'failed to setup':

image

How to reproduce the issue

Steps to reproduce the behavior: Updated to latest (1.4.1) version

Expected behavior

No error after update.

Screenshots

Software versions

Home Assistant version: HA 2023.4.6 openmediavault integration version: 1.4.1 openmediavault software version: 6.3.10-2 (Shaitan)

Diagnostics data

Traceback/Error logs

Log file attached. home-assistant_2023-04-29T12-33-51.141Z.log

Additional context

tomaae commented 1 year ago

ok, so you are failing on compose plugin. I see you have it installed, but API returns error 500. can you give me screenshots from OMV UI for every compose page? are they loaging correctly?

SamJongenelen commented 1 year ago

I have the same i guess, NoneType is not iterable. I dont use the compose, i use portainer so maybe i need to setup OMV correctly indeed

tomaae commented 1 year ago

OMV still should not respond with code 500, that means internal error. Need to figure out why and if its fixable. Best would be if I could reproduce the issue. I guess you cant see containers in OMV UI if you use portainer?

SamJongenelen commented 1 year ago

Well, when i navigated in omv i got error 500 too i guess its the same cause. Instruction pretty clear, but on mobile so will need to update later. Screenshot_20230430-100834

SamJongenelen commented 1 year ago

Ok to confirm, as soon as i gave OMV compose a file share to work from, it stopped giving 500 in the OMV UI and the integration started working again.

Didnt give it an existing path btw, just something

cdjockey commented 1 year ago

Ok to confirm, as soon as i gave OMV compose a file share to work from, it stopped giving 500 in the OMV UI and the integration started working again.

Didnt give it an existing path btw, just something

I also just did this and it also seems to have solved the issue, thanks!

Maybe OMV changed something during the last update?

SamJongenelen commented 1 year ago

No this integration got a lot of new functions :) . The OMV api was always (6 months or so?) erroring just never consumed by this integration before

tomaae commented 1 year ago

I see, so it fails if shared folder is not set in compose settings? If so, we need check for that too.

SamJongenelen commented 1 year ago

Yeah maybe you can catch that and load the other parts of the integration, right?

tomaae commented 1 year ago

more like stop plugin from loading in integration and show warning. since compose query fails in that case.