tomaae / homeassistant-openmediavault

OpenMediaVault integration for Home Assistant
Apache License 2.0
109 stars 16 forks source link

[Bug] Entity names are generic, do not match device overview page. #137

Open kevinsargent opened 11 months ago

kevinsargent commented 11 months ago

Describe the issue

Entity names are generic values, not specific, useable names. For example: Go to an HA OMV device overview page such as https://ha/config/devices/device/fbb8eda0a5e83b591d5b1d8133b2a0c3 and the entities listed are named correctly, for filesystems as an example, sda1, sdb1, sdc1, etc..

But when viewed from the HA entities list, they are generic such as "OMVfilesystem" with entity ID of "sensor.omv_filesystem" "sensor.omv_filesystem_2", "sensor.omv_filesystem_3" etc... not very useable in building dashboards or monitoring.

Same situation applies to all OMV devices in HA.

How to reproduce the issue

  1. Go to OMV integration in HA and look at a device and it's listed entities. This appears correct.
  2. Go to Home Assistant entities and filter for omv entities and they are very generically named & ID'd

Expected behavior

I would expect the entity names to be in line with what is shown in the device overview page. Instead of OMV Filesystem / sensor.omv_filesystem I would expect: OMV Filesystem sda1 / sensor.omv_filesystem_sda1

Screenshots

image image

Software versions

HA Version Home Assistant 2023.10.1

OMV Integration 1.4.2

OMV Version Firmware: 6.9.3-1 (Shaitan)

Diagnostics data

{ "home_assistant": { "installation_type": "Home Assistant Container", "version": "2023.10.1", "dev": false, "hassio": false, "virtualenv": false, "python_version": "3.11.5", "docker": true, "arch": "x86_64", "timezone": "America/Los_Angeles", "os_name": "Linux", "os_version": "6.1.0-0.deb11.11-amd64", "run_as_root": true }, "custom_components": { "hacs": { "version": "1.32.1", "requirements": [ "aiogithubapi>=22.10.1" ] }, "openmediavault": { "version": "0.0.0", "requirements": [] }, "sensorpush": { "version": "0.1.4", "requirements": [ "pysensorpush>=0.1.7" ] } }, "integration_manifest": { "domain": "openmediavault", "name": "OpenMediaVault", "codeowners": [ "@tomaae" ], "config_flow": true, "dependencies": [], "documentation": "https://github.com/tomaae/homeassistant-openmediavault", "iot_class": "local_polling", "issue_tracker": "https://github.com/tomaae/homeassistant-openmediavault/issues", "requirements": [], "version": "0.0.0", "is_built_in": false }, "data": { "entry": { "data": { "name": "OMV", "host": "192.168.1.20", "username": "REDACTED", "password": "REDACTED", "ssl": false, "verify_ssl": false }, "options": {} }, "data": { "hwinfo": { "hostname": "ks-omv.ksargent.com", "version": "6.9.3-1 (Shaitan)", "cpuUsage": 0.0, "memTotal": 15620849664, "memUsed": 3025989632, "loadAverage_1": 0.15, "loadAverage_5": 0.21, "loadAverage_15": 0.19, "uptime": "391577.66", "configDirty": false, "rebootRequired": false, "availablePkgUpdates": 0, "memUsage": 19.4, "pkgUpdatesAvailable": false, "uptimeEpoch": "2023-10-12T04:43:19+00:00" }, "plugin": { "openmediavault-anacron": { "name": "openmediavault-anacron", "installed": false }, "openmediavault-apttool": { "name": "openmediavault-apttool", "installed": false }, "openmediavault-autoshutdown": { "name": "openmediavault-autoshutdown", "installed": false }, "openmediavault-backup": { "name": "openmediavault-backup", "installed": false }, "openmediavault-borgbackup": { "name": "openmediavault-borgbackup", "installed": false }, "openmediavault-clamav": { "name": "openmediavault-clamav", "installed": false }, "openmediavault-compose": { "name": "openmediavault-compose", "installed": true }, "openmediavault-cputemp": { "name": "openmediavault-cputemp", "installed": false }, "openmediavault-diskstats": { "name": "openmediavault-diskstats", "installed": true }, "openmediavault-downloader": { "name": "openmediavault-downloader", "installed": false }, "openmediavault-fail2ban": { "name": "openmediavault-fail2ban", "installed": false }, "openmediavault-filebrowser": { "name": "openmediavault-filebrowser", "installed": false }, "openmediavault-flashmemory": { "name": "openmediavault-flashmemory", "installed": false }, "openmediavault-forkeddaapd": { "name": "openmediavault-forkeddaapd", "installed": false }, "openmediavault-ftp": { "name": "openmediavault-ftp", "installed": false }, "openmediavault-kernel": { "name": "openmediavault-kernel", "installed": false }, "openmediavault-kvm": { "name": "openmediavault-kvm", "installed": false }, "openmediavault-locate": { "name": "openmediavault-locate", "installed": false }, "openmediavault-luksencryption": { "name": "openmediavault-luksencryption", "installed": false }, "openmediavault-lvm2": { "name": "openmediavault-lvm2", "installed": false }, "openmediavault-mergerfs": { "name": "openmediavault-mergerfs", "installed": true }, "openmediavault-minidlna": { "name": "openmediavault-minidlna", "installed": false }, "openmediavault-nut": { "name": "openmediavault-nut", "installed": true }, "openmediavault-omvextrasorg": { "name": "openmediavault-omvextrasorg", "installed": true }, "openmediavault-onedrive": { "name": "openmediavault-onedrive", "installed": false }, "openmediavault-owntone": { "name": "openmediavault-owntone", "installed": false }, "openmediavault-photoprism": { "name": "openmediavault-photoprism", "installed": false }, "openmediavault-remotemount": { "name": "openmediavault-remotemount", "installed": false }, "openmediavault-resetperms": { "name": "openmediavault-resetperms", "installed": false }, "openmediavault-rsnapshot": { "name": "openmediavault-rsnapshot", "installed": false }, "openmediavault-s3": { "name": "openmediavault-s3", "installed": false }, "openmediavault-sftp": { "name": "openmediavault-sftp", "installed": false }, "openmediavault-shairport": { "name": "openmediavault-shairport", "installed": false }, "openmediavault-sharerootfs": { "name": "openmediavault-sharerootfs", "installed": true }, "openmediavault-snapraid": { "name": "openmediavault-snapraid", "installed": true }, "openmediavault-snmp": { "name": "openmediavault-snmp", "installed": false }, "openmediavault-symlinks": { "name": "openmediavault-symlinks", "installed": true }, "openmediavault-tftp": { "name": "openmediavault-tftp", "installed": false }, "openmediavault-tgt": { "name": "openmediavault-tgt", "installed": false }, "openmediavault-usbbackup": { "name": "openmediavault-usbbackup", "installed": false }, "openmediavault-wakealarm": { "name": "openmediavault-wakealarm", "installed": false }, "openmediavault-wetty": { "name": "openmediavault-wetty", "installed": false }, "openmediavault-wireguard": { "name": "openmediavault-wireguard", "installed": false }, "openmediavault-wol": { "name": "openmediavault-wol", "installed": false }, "openmediavault-zfs": { "name": "openmediavault-zfs", "installed": false } }, "disk": { "nvme0n1": { "devicename": "nvme0n1", "canonicaldevicefile": "/dev/nvme0n1", "size": "256060514304", "vendor": "0x15b7", "model": "WDC PC SN530 SDBPNPZ-256G-1006", "description": "WDC PC SN530 SDBPNPZ-256G-1006 [/dev/nvme0n1, 238.47 GiB]", "serialnumber": "204914801093", "israid": false, "isroot": true, "isreadonly": false, "temperature": 33, "Raw_Read_Error_Rate": "unknown", "Spin_Up_Time": "unknown", "Start_Stop_Count": "unknown", "Reallocated_Sector_Ct": "unknown", "Seek_Error_Rate": "unknown", "Load_Cycle_Count": "unknown", "UDMA_CRC_Error_Count": "unknown", "Multi_Zone_Error_Rate": "unknown" }, "sda": { "devicename": "sda", "canonicaldevicefile": "/dev/sda", "size": "8001563222016", "vendor": "ATA", "model": "ST8000VN004-2M2101", "description": "ST8000VN004-2M2101 [/dev/sda, 7.27 TiB]", "serialnumber": "WKD2YYRY", "israid": false, "isroot": false, "isreadonly": false, "temperature": 33, "Raw_Read_Error_Rate": 120175912, "Spin_Up_Time": 0, "Start_Stop_Count": 22, "Reallocated_Sector_Ct": 0, "Seek_Error_Rate": 506049540, "Load_Cycle_Count": 2299, "UDMA_CRC_Error_Count": 0, "Multi_Zone_Error_Rate": "unknown" }, "sdb": { "devicename": "sdb", "canonicaldevicefile": "/dev/sdb", "size": "8001563222016", "vendor": "ATA", "model": "ST8000VN004-2M2101", "description": "ST8000VN004-2M2101 [/dev/sdb, 7.27 TiB]", "serialnumber": "WKD3393V", "israid": false, "isroot": false, "isreadonly": false, "temperature": 34, "Raw_Read_Error_Rate": 138204096, "Spin_Up_Time": 0, "Start_Stop_Count": 22, "Reallocated_Sector_Ct": 0, "Seek_Error_Rate": 503222569, "Load_Cycle_Count": 2246, "UDMA_CRC_Error_Count": 0, "Multi_Zone_Error_Rate": "unknown" }, "sdc": { "devicename": "sdc", "canonicaldevicefile": "/dev/sdc", "size": "8001563222016", "vendor": "ATA", "model": "ST8000VN004-2M2101", "description": "ST8000VN004-2M2101 [/dev/sdc, 7.27 TiB]", "serialnumber": "WKD32WHV", "israid": false, "isroot": false, "isreadonly": false, "temperature": 34, "Raw_Read_Error_Rate": 594801, "Spin_Up_Time": 0, "Start_Stop_Count": 22, "Reallocated_Sector_Ct": 0, "Seek_Error_Rate": 486456472, "Load_Cycle_Count": 2234, "UDMA_CRC_Error_Count": 0, "Multi_Zone_Error_Rate": "unknown" }, "sdd": { "devicename": "sdd", "canonicaldevicefile": "/dev/sdd", "size": "960197124096", "vendor": "ATA", "model": "MZ7LH960HBJR0D3", "description": "MZ7LH960HBJR0D3 [/dev/sdd, 894.25 GiB]", "serialnumber": "S5YHNE0NA06897", "israid": false, "isroot": false, "isreadonly": false, "temperature": 29, "Raw_Read_Error_Rate": 0, "Spin_Up_Time": "unknown", "Start_Stop_Count": "unknown", "Reallocated_Sector_Ct": 0, "Seek_Error_Rate": "unknown", "Load_Cycle_Count": "unknown", "UDMA_CRC_Error_Count": 0, "Multi_Zone_Error_Rate": "unknown" }, "sde": { "devicename": "sde", "canonicaldevicefile": "/dev/sde", "size": "960197124096", "vendor": "ATA", "model": "MZ7LH960HBJR0D3", "description": "MZ7LH960HBJR0D3 [/dev/sde, 894.25 GiB]", "serialnumber": "S5YHNE0NA06893", "israid": false, "isroot": false, "isreadonly": false, "temperature": 30, "Raw_Read_Error_Rate": 0, "Spin_Up_Time": "unknown", "Start_Stop_Count": "unknown", "Reallocated_Sector_Ct": 0, "Seek_Error_Rate": "unknown", "Load_Cycle_Count": "unknown", "UDMA_CRC_Error_Count": 0, "Multi_Zone_Error_Rate": "unknown" }, "sdf": { "devicename": "sdf", "canonicaldevicefile": "/dev/sdf", "size": "8001563222016", "vendor": "ATA", "model": "ST8000VN004-2M2101", "description": "ST8000VN004-2M2101 [/dev/sdf, 7.27 TiB]", "serialnumber": "WKD32V5D", "israid": false, "isroot": false, "isreadonly": false, "temperature": 32, "Raw_Read_Error_Rate": 177374120, "Spin_Up_Time": 0, "Start_Stop_Count": 8, "Reallocated_Sector_Ct": 0, "Seek_Error_Rate": 4432250, "Load_Cycle_Count": 96, "UDMA_CRC_Error_Count": 0, "Multi_Zone_Error_Rate": "unknown" }, "sdg": { "devicename": "sdg", "canonicaldevicefile": "/dev/sdg", "size": "4000787029504", "vendor": "Seagate", "model": "Expansion", "description": "Expansion [/dev/sdg, 3.63 TiB]", "serialnumber": "NAAX02TC", "israid": false, "isroot": false, "isreadonly": false, "temperature": 0, "Raw_Read_Error_Rate": "unknown", "Spin_Up_Time": "unknown", "Start_Stop_Count": "unknown", "Reallocated_Sector_Ct": "unknown", "Seek_Error_Rate": "unknown", "Load_Cycle_Count": "unknown", "UDMA_CRC_Error_Count": "unknown", "Multi_Zone_Error_Rate": "unknown" }, "sdh": { "devicename": "sdh", "canonicaldevicefile": "/dev/sdh", "size": "4000787029504", "vendor": "Seagate", "model": "Expansion", "description": "Expansion [/dev/sdh, 3.63 TiB]", "serialnumber": "NAAX0PNW", "israid": false, "isroot": false, "isreadonly": false, "temperature": 0, "Raw_Read_Error_Rate": "unknown", "Spin_Up_Time": "unknown", "Start_Stop_Count": "unknown", "Reallocated_Sector_Ct": "unknown", "Seek_Error_Rate": "unknown", "Load_Cycle_Count": "unknown", "UDMA_CRC_Error_Count": "unknown", "Multi_Zone_Error_Rate": "unknown" } }, "fs": { "92b05d7c-4ad5-4c7c-bfee-d50a733448a9": { "uuid": "92b05d7c-4ad5-4c7c-bfee-d50a733448a9", "parentdevicefile": "/dev/nvme0n1", "label": "", "type": "ext4", "mounted": true, "devicename": "nvme0n1p1", "available": 207.3, "size": 232.7, "percentage": 7, "_readonly": true, "_used": true, "propreadonly": false }, "31599b49-025b-4545-a475-e3261649cff3": { "uuid": "31599b49-025b-4545-a475-e3261649cff3", "parentdevicefile": "/dev/sdc", "label": "", "type": "ext4", "mounted": true, "devicename": "sdc1", "available": 5099.4, "size": 7392.2, "percentage": 32, "_readonly": false, "_used": true, "propreadonly": false }, "58bbb442-fb17-47da-9787-a22395e1ae5e": { "uuid": "58bbb442-fb17-47da-9787-a22395e1ae5e", "parentdevicefile": "/dev/sdb", "label": "", "type": "ext4", "mounted": true, "devicename": "sdb1", "available": 5101.1, "size": 7392.2, "percentage": 31, "_readonly": false, "_used": true, "propreadonly": false }, "e05187fa-df7e-4043-ad35-ee545b0601af": { "uuid": "e05187fa-df7e-4043-ad35-ee545b0601af", "parentdevicefile": "/dev/sda", "label": "", "type": "ext4", "mounted": true, "devicename": "sda1", "available": 7201.9, "size": 7392.2, "percentage": 3, "_readonly": false, "_used": true, "propreadonly": false }, "63c3d5c5-a8ac-4d09-98d3-81561b488aa0": { "uuid": "63c3d5c5-a8ac-4d09-98d3-81561b488aa0", "parentdevicefile": "/dev/sdd", "label": "", "type": "ext4", "mounted": true, "devicename": "sdd1", "available": 736.0, "size": 879.1, "percentage": 17, "_readonly": false, "_used": true, "propreadonly": false }, "466bb25a-52f0-43d2-8f27-b4a63777b980": { "uuid": "466bb25a-52f0-43d2-8f27-b4a63777b980", "parentdevicefile": "/dev/sde", "label": "", "type": "ext4", "mounted": true, "devicename": "sde1", "available": 878.9, "size": 879.1, "percentage": 1, "_readonly": false, "_used": true, "propreadonly": false }, "2ab23b01-38ea-4c6f-8d07-75f8ec1e3fa7": { "uuid": "2ab23b01-38ea-4c6f-8d07-75f8ec1e3fa7", "parentdevicefile": "/dev/sdf", "label": "", "type": "ext4", "mounted": true, "devicename": "sdf1", "available": 7204.2, "size": 7392.2, "percentage": 3, "_readonly": false, "_used": true, "propreadonly": false }, "fe4a25b0-c6d2-4949-b1f7-6609d06b9888": { "uuid": "fe4a25b0-c6d2-4949-b1f7-6609d06b9888", "parentdevicefile": "/dev/sdg", "label": "", "type": "ext4", "mounted": true, "devicename": "sdg1", "available": 854.0, "size": 3666.4, "percentage": 77, "_readonly": false, "_used": true, "propreadonly": false }, "2f118b9e-8680-40fa-85a5-a22a1c8657d1": { "uuid": "2f118b9e-8680-40fa-85a5-a22a1c8657d1", "parentdevicefile": "/dev/sdh", "label": "", "type": "ext4", "mounted": true, "devicename": "sdh1", "available": 3666.4, "size": 3666.4, "percentage": 1, "_readonly": false, "_used": true, "propreadonly": false }, "412da0e0-45c6-4fd2-8dd0-86073e5ef0e0": { "uuid": "412da0e0-45c6-4fd2-8dd0-86073e5ef0e0", "parentdevicefile": "False", "label": "hdd", "type": "fuse.mergerfs", "mounted": true, "devicename": "/srv/mergerfs/hdd", "available": 19507.2, "size": 22176.6, "percentage": 13, "_readonly": false, "_used": true, "propreadonly": false }, "49e9ae62-b958-4ceb-9482-069e602f5bda": { "uuid": "49e9ae62-b958-4ceb-9482-069e602f5bda", "parentdevicefile": "False", "label": "Backup", "type": "fuse.mergerfs", "mounted": true, "devicename": "/srv/mergerfs/Backup", "available": 4520.5, "size": 7332.9, "percentage": 39, "_readonly": false, "_used": true, "propreadonly": false } }, "service": { "Docker": { "name": "Docker", "title": "Docker", "enabled": true, "running": true }, "nfs": { "name": "nfs", "title": "NFS", "enabled": false, "running": false }, "nut": { "name": "nut", "title": "UPS", "enabled": false, "running": true }, "rsyncd": { "name": "rsyncd", "title": "RSync server", "enabled": true, "running": true }, "samba": { "name": "samba", "title": "SMB/CIFS", "enabled": true, "running": true }, "ssh": { "name": "ssh", "title": "SSH", "enabled": true, "running": true } }, "network": { "8708eb12-667b-44a3-945e-042110cf4a98": { "uuid": "8708eb12-667b-44a3-945e-042110cf4a98", "devicename": "eno1", "type": "ethernet", "method": "static", "address": "192.168.1.20", "netmask": "255.255.255.0", "gateway": "192.168.1.1", "mtu": 1500, "link": true, "wol": false, "rx-current": 634729841428.0, "tx-current": 13533469130.0, "rx-previous": 634729841428.0, "tx-previous": 13533469130.0, "rx": 12957713.87, "tx": 304983.07 }, "d9d96088-afa2-47ea-954e-ea5b17aaa91a": { "uuid": "d9d96088-afa2-47ea-954e-ea5b17aaa91a", "devicename": "eno1.3", "type": "vlan", "method": "static", "address": "192.168.3.20", "netmask": "255.255.255.0", "gateway": "192.168.3.1", "mtu": 1500, "link": true, "wol": false, "rx-current": 949361257.0, "tx-current": 227284759.0, "rx-previous": 949361257.0, "tx-previous": 227284759.0, "rx": 8005.47, "tx": 10578.53 }, "fa4b1c66-ef79-11e5-87a0-0002b3a176b4": { "uuid": "fa4b1c66-ef79-11e5-87a0-0002b3a176b4", "devicename": "wlp3s0", "type": "wifi", "method": "unknown", "address": "", "netmask": "", "gateway": "", "mtu": 1500, "link": false, "wol": false, "rx-current": 225869355.0, "tx-current": 11182585.0, "rx-previous": 225869355.0, "tx-previous": 11182585.0, "rx": 0.0, "tx": 0.0 } }, "kvm": {}, "compose": { "home-assistant": { "name": "home-assistant", "image": "homeassistant/home-assistant:latest", "project": "unknown", "service": "unknown", "created": "2023-10-11 22:35:17 -0700 PDT", "state": "running" }, "unifi-lsio": { "name": "unifi-lsio", "image": "lscr.io/linuxserver/unifi-controller:7.4.162", "project": "unknown", "service": "unknown", "created": "2023-10-03 20:36:50 -0700 PDT", "state": "running" }, "pihole": { "name": "pihole", "image": "pihole/pihole:latest", "project": "unknown", "service": "unknown", "created": "2023-10-02 18:11:37 -0700 PDT", "state": "running" }, "swag": { "name": "swag", "image": "linuxserver/swag:latest", "project": "unknown", "service": "unknown", "created": "2023-10-02 17:52:09 -0700 PDT", "state": "running" }, "mosquitto": { "name": "mosquitto", "image": "eclipse-mosquitto:latest", "project": "unknown", "service": "unknown", "created": "2023-10-02 17:51:06 -0700 PDT", "state": "running" }, "frigate": { "name": "frigate", "image": "ghcr.io/blakeblackshear/frigate:stable", "project": "unknown", "service": "unknown", "created": "2023-10-01 20:11:29 -0700 PDT", "state": "exited" }, "emby": { "name": "emby", "image": "lscr.io/linuxserver/emby:latest", "project": "unknown", "service": "unknown", "created": "2023-10-01 19:51:25 -0700 PDT", "state": "running" }, "portainer": { "name": "portainer", "image": "portainer/portainer-ce:latest", "project": "unknown", "service": "unknown", "created": "2023-10-01 19:43:05 -0700 PDT", "state": "running" } } } } }

Traceback/Error logs

Additional context

tomaae commented 10 months ago

I'm aware of that, its related to new way HA is hangling devices. This is already fixed in one of my other integrations, so once I finish with all features I will port the core across all my other integrations.

707kevin commented 10 months ago

I'm aware of that, its related to new way HA is hangling devices. This is already fixed in one of my other integrations, so once I finish with all features I will port the core across all my other integrations.

Excellent, thank you very much for this integration!

CodingSquirrel commented 8 months ago

@tomaae is this still planned? If not soon, can you point to how this was fixed in the other integration and I can try to make a PR?

tomaae commented 8 months ago

yes it is planned, but I would not expect it soon. It would not be easy to pick out just that particular change for PR. I expect to get back to coding after my vacation ends next week, but first I will be working on finishing new integration model, before I'm ready to port it to all my integrations.